summaryrefslogtreecommitdiff
diff options
authorJeff Lane <jeffrey.lane@canonical.com>2015-07-07 18:13:42 -0400
committerJeff Lane <jeffrey.lane@canonical.com>2015-07-07 18:13:42 -0400
commit57451ae64e7f28746b22dd84c55504b5395a721b (patch)
tree6f822def5b62a914bff3af51a967d44010ea10c9
parentc233672d73d69e4bb5b201d3447bf64f106ed0a7 (diff)
Change ipmi_test to fail any time a module doesn't load
-rwxr-xr-xbin/ipmi_test9
1 files changed, 3 insertions, 6 deletions
diff --git a/bin/ipmi_test b/bin/ipmi_test
index 403f572..32d5773 100755
--- a/bin/ipmi_test
+++ b/bin/ipmi_test
@@ -8,12 +8,9 @@ for module in ipmi_si ipmi_devintf ipmi_msghandler; do
echo "Loading $module..."
modprobe $module
result=$?
- # if ipmi_si fails to load, it's safe to assume the system
- # has no BMC, so we'll just politely exit.
- if [ $result -eq 1 ] && [ "$module" = "ipmi_si" ]; then
- echo "WARNING: No BMC found. Aborting."
- exit 0
- elif [ $result -eq 1 ]; then
+ # If the IPMI drivers don't load, it could be the system has no BMC, or
+ # the IPMI driver is bad. We should error and Fail here.
+ if [ $result -eq 1 ]; then
echo "ERROR: Unable to load module $module" >&2
echo "Aborting IPMI test run." >&2
exit 1