summaryrefslogtreecommitdiff
diff options
authorJonathan Cave <jonathan.cave@canonical.com>2021-04-09 17:47:30 +0100
committerJonathan Cave <jonathan.cave@canonical.com>2021-04-09 17:47:30 +0100
commit008ae14fc3e6274fe1945d516ab6b09f80b92e67 (patch)
tree47abcaefe1010cfe6b9ea7ac0964b554518f1afc
parente3708c7d2ef8a750570f9c8b2322a4c044b3342b (diff)
Fix: ensure all plans have -manual variants
Ensure all plans have full/automated/manual variants. Also tidy up some wording and consistency of captilisation.
-rw-r--r--units/i2c/category.pxu2
-rw-r--r--units/i2c/jobs.pxu34
-rw-r--r--units/i2c/manifest.pxu2
-rw-r--r--units/i2c/test-plan.pxu15
4 files changed, 27 insertions, 26 deletions
diff --git a/units/i2c/category.pxu b/units/i2c/category.pxu
index b0020b1..16f0bfa 100644
--- a/units/i2c/category.pxu
+++ b/units/i2c/category.pxu
@@ -6,4 +6,4 @@
unit: category
id: i2c
-_name: I2C (Inter-Integrated Circuit)
+_name: I²C (Inter-Integrated Circuit)
diff --git a/units/i2c/jobs.pxu b/units/i2c/jobs.pxu
index b0ff9d7..fa3e0b5 100644
--- a/units/i2c/jobs.pxu
+++ b/units/i2c/jobs.pxu
@@ -6,20 +6,17 @@
unit: job
id: i2c/i2c-bus-detect
-_summary: Check number of detected I2C bus
-_purpose:
- Verify if number of detected I2C bus is as expected
-_steps:
- 1. This task is fully automatic, when expected i2c bus number($I2C_BUS_NUMBER)
- is set, this job will verify if detected number of i2c bus is as expected.
- 2. If expected i2c bus number is not set, this job will pass if system
- detected there's at least one i2c bus.
+_summary: Check presence of an I²C bus
+_description:
+ If an expected number of I²C buses is provided, the job will verify the
+ detected number is correct. If the expected number of buses is not provided
+ the job will pass if at least one I²C bus is detected.
command:
- if [ -z "${I2C_BUS_NUMBER+x}" ]; then
- i2c_driver_test.py bus
- else
- i2c_driver_test.py bus -b "$I2C_BUS_NUMBER"
- fi
+ if [ -z "${I2C_BUS_NUMBER+x}" ]; then
+ i2c_driver_test.py bus
+ else
+ i2c_driver_test.py bus -b "$I2C_BUS_NUMBER"
+ fi
user: root
plugin: shell
category_id: i2c
@@ -30,14 +27,11 @@ imports: from com.canonical.plainbox import manifest
unit: job
id: i2c/i2c-device-detect
-_summary: Check if any I2C device detected
-_purpose:
- Verify if there's any I2C device
-_steps:
- 1. This task is fully automatic, test will pass if there's at least one
- i2c device detected on any I2C bus.
+_summary: Check if any I²C devices can be detected
+_description:
+ The test will pass if there's at least one I²C device detected on any I²C bus.
command:
- i2c_driver_test.py device
+ i2c_driver_test.py device
user: root
plugin: shell
category_id: i2c
diff --git a/units/i2c/manifest.pxu b/units/i2c/manifest.pxu
index ac944f3..8e39de2 100644
--- a/units/i2c/manifest.pxu
+++ b/units/i2c/manifest.pxu
@@ -6,5 +6,5 @@
unit: manifest entry
id: has_i2c
-_name: An I2C bus
+_name: An I²C bus
value-type: bool
diff --git a/units/i2c/test-plan.pxu b/units/i2c/test-plan.pxu
index 99e9aaf..fc626df 100644
--- a/units/i2c/test-plan.pxu
+++ b/units/i2c/test-plan.pxu
@@ -1,15 +1,22 @@
id: i2c-full
unit: test plan
-_name: I2c tests
-_description: QA i2c tests for Snappy Ubuntu Core devices
+_name: I²C tests
+_description: I²C tests for Ubuntu Core devices
include:
nested_part:
+ i2c-manual
i2c-automated
+id: i2c-manual
+unit: test plan
+_name: Manual I²C tests
+_description: Manual I²C tests for Ubuntu Core devices
+include:
+
id: i2c-automated
unit: test plan
-_name: Automated i2c tests
-_description: Automated i2c tests for Snappy Ubuntu Core devices
+_name: Automated I²C tests
+_description: Automated I²C tests for Ubuntu Core devices
include:
i2c/i2c-bus-detect
i2c/i2c-device-detect