summaryrefslogtreecommitdiff
diff options
authorAndrea Azzarone <azzaronea@gmail.com>2012-09-12 08:23:21 -0400
committerTarmac <>2012-09-12 08:23:21 -0400
commit62b65c01ffad5187da882b17c6057e317ae0e4cb (patch)
treebcaf13bbd3766bd859ba6d6cf698c06487a6b00c
parent09f7b02486e1c0c8db5a76768bd92dd90d54042e (diff)
parent25ea1eb101388c87df545c8abcea3a1b85f89e93 (diff)
Fix crash in unity::dash::CoverflowResultView::Impl::Impl(). Fixes: https://bugs.launchpad.net/bugs/1047420. Approved by Marco Trevisan (TreviƱo).
(bzr r2682)
-rwxr-xr-xdash/CoverflowResultView.cpp11
1 files changed, 4 insertions, 7 deletions
diff --git a/dash/CoverflowResultView.cpp b/dash/CoverflowResultView.cpp
index c73b4e109..8d40cb00b 100755
--- a/dash/CoverflowResultView.cpp
+++ b/dash/CoverflowResultView.cpp
@@ -161,11 +161,12 @@ CoverflowResultView::Impl::Impl(CoverflowResultView *parent)
ubus_.RegisterInterest(UBUS_DASH_PREVIEW_NAVIGATION_REQUEST, [&] (GVariant* data) {
int nav_mode = 0;
- gchar* uri = NULL;
- gchar* proposed_unique_id = NULL;
+ glib::String uri;
+ glib::String proposed_unique_id;
+
g_variant_get(data, "(iss)", &nav_mode, &uri, &proposed_unique_id);
- if (std::string(proposed_unique_id) != parent_->unique_id())
+ if (proposed_unique_id.Str() != parent_->unique_id())
return;
unsigned num_results = coverflow_->model()->Items().size();
@@ -192,10 +193,6 @@ CoverflowResultView::Impl::Impl(CoverflowResultView *parent)
ubus_.SendMessage(UBUS_DASH_PREVIEW_INFO_PAYLOAD,
g_variant_new("(iii)", 0, left_results, right_results));
}
-
- g_free(uri);
- g_free(proposed_unique_id);
-
});
}