Skip to content

Support filenames with multiple dots #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mm-gmbd wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Support filenames with multiple dots #29

mm-gmbd wants to merge 2 commits into from

Conversation

@mm-gmbd
Copy link

@mm-gmbd mm-gmbd commented Apr 20, 2022 •
edited
Loading

Addresses issue #28
mm-gmbd
mm-gmbd commented Apr 20, 2022
View reviewed changes
tests/unit/findIncludeTags.js
var file = fs.readFileSync('tests/data/docs/has_include_tags.md').toString();
var findHeadingTags = markdownInclude.findIncludeTags(file);
assert.equal(findHeadingTags.length, 2, 'Heading tags length match');
assert.equal(findHeadingTags.length, 3, 'Heading tags length match');
Copy link
Author

@mm-gmbd mm-gmbd Apr 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note I was unable to test these changes, when I run npm test I get the following error:

% npm run test > markdown-include-etn@0.4.4 test > node_modules/.bin/intern-client config=tests/intern.js internal/modules/cjs/loader.js:883 throw err; ^ Error: Cannot find module 'dojo/dojo' Require stack: - /repos/markdown-include/node_modules/@theintern/dojo/dojo.js - /repos/markdown-include/node_modules/intern/client.js - /repos/markdown-include/node_modules/intern/bin/intern-client.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@mm-gmbd