Skip to content

Conversation

@profetia
Copy link
Member

@profetia profetia commented Dec 21, 2025

Closes #16281

changelog: [cmp_null] Don't suggest to inline macro contents instead of calling them

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 21, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jarcho Jarcho added this pull request to the merge queue Dec 21, 2025
@Jarcho
Copy link
Contributor

Jarcho commented Dec 21, 2025

For future reference if you want to add multiple things to the changelog you need to prefix each line with changelog:. Also documentation changes don't need changelog notes.

Your phrasing for the macro fix also doesn't really make sense. Macros are never mangled so a suggestion can't unmangle them. The suggestion we generate is mangled because it inlines the macro contents. Alternative wordings could be "Don't mangle suggestions involving macro calls" or "Don't suggest to inline macro contents instead of calling them".

Merged via the queue into rust-lang:master with commit 26a5677 Dec 21, 2025
13 of 15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants