Added new lint for map_or(..., identity) #16052
Open
+212 −84
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Introduce a new lint for mapping the identity function with
map_oroverOptionandResult.Lints:
Into
Fixes #15801
We had some discussions with @ada4a about naming on issue #15801 , a summary here.
There's a question about naming for this lint, there's already
unnecessary_option_map_or_elseandunnecessary_result_map_or_else, but I think having two lints doesn't make sense in this case.unnecessary_map_orcould be a reasonable name for this new lint, but it's already takenchangelog: [
map_or_identity]: new lint