Improve doc comment code language tag parsing, don't use a full parser #15967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Some changes occurred in clippy_lints/src/doc cc @notriddle |
rustbot added the S-waiting-on-review Collaborator
| Lintcheck changes for 0ff3a38
This comment will be updated if you push new changes |
dswij approved these changes Oct 30, 2025
rustbot removed the S-waiting-on-review Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Now only tokenizes the contents of code blocks instead of spawning a thread for a full parser
The language tag handling now correctly picks up things like
rust, ignoreno_test(#10491) is no longer specially handled, rustdoc considersrust,no_testto be a regular testchangelog: [
needless_doctest_main], [test_attr_in_doctest]: now handles whitespace in language tags