chore(empty_enum): rename to empty_enums #15912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added needs-fcp S-waiting-on-review 
Collaborator
Contributor Author
rustbot added S-blocked 
ada4a force-pushed the empty_enums branch 2 times, most recently from 52c60d6 to eb25f28 Compare Contributor Author
| PR was merged, so @rustbot ready |
rustbot added S-waiting-on-review 
Member
| @ada4a thanks! Can we squash the commits? |
According to the lint naming guidelines[^1], lint names should use the plural form. [^1]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
Collaborator
| This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor Author
| It was just one commit, but on top of the two commits from the previous PR. Rebased^^ |
dswij approved these changes Oct 21, 2025
This comment was marked as outdated.
This comment was marked as outdated.
rustbot removed the S-waiting-on-review Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
According to the lint naming guidelines1, lint names should use the
plural form.
changelog: [
empty_enum]: rename toempty_enumsFootnotes
https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints ↩