New lint: missing_workspace_lints

[BenjaminBrienen]

Adds a new lint for when your workspace has a lint configuration table, but a member of the workspace implicitly does not inherit that configuration. This has bitten me in the butt many times in my large workspace with many crates where I forget to add lints.workspace = true.

Example in rust-analyzer!

Worked on with @NateD-MSFT during the RustWeek workshop.

changelog: [missing_workspace_lints]: Added new lint to warn when a project is in a workspace with workspace lint configuration, but has not explicitly configured lints.workspace.

[rustbot]

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[samueltardieu]

I think this should be a Cargo lint instead. "lints" are probably not the only key which should be checked, for example edition, rust-version and license should be as well.

[samueltardieu]

Worked on with @NateD-MSFT during the RustWeek workshop.

r? @llogiq

[BenjaminBrienen]

Clippy already has a few cargo lints and I think it even checks for missing basic metadata (allow by default). If they get moved into cargo itself, this could move with them?

[samueltardieu]

Dear contributor. Clippy has entered a feature freeze period and will not be integrating new lints for a few weeks. You can rest assured that the Clippy team will review and discuss your proposal at the end of the feature freeze period.

If you wish to contribute to Clippy in the meantime, do not hesitate to read the pinned tracking issue about the feature freeze itself.

@rustbot label +A-lint +S-blocked -S-waiting-on-review
@rustbot note "Feature freeze"

[ada4a]

@rustbot note remove "Feature freeze"