Rewrite lifetimes lint pass #14715
Open
Rewrite lifetimes lint pass #14715
+3,545 −1,914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
rustbot added the S-waiting-on-review Collaborator
| ☔ The latest upstream changes (possibly 03a5b6b) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
| r? clippy |
Contributor
| The dogfood error hints at a missing semicolon. Should be easy to fix. |
Contributor
| This will take more time to review than I have right now, but I have a 9 hour flight tomorrow, so I could pull that branch before departure... |
Contributor
| In any event, add a semicolon to |
Jarcho force-pushed the lifetime_ice_2 branch 2 times, most recently from 556bd37 to da1ca94 Compare 
| Lintcheck changes for da1ca94
This comment will be updated if you push new changes |
Jarcho force-pushed the lifetime_ice_2 branch from da1ca94 to 2d939c1 Compare This comment has been minimized.
This comment has been minimized.
Jarcho force-pushed the lifetime_ice_2 branch 2 times, most recently from 7b38cc9 to b58863d Compare Rename `get_source_text` and `check_source_text` to `get_text` and `check_text`.
* Change lint message to not mention the lifetime names * Only point to the lifetime definition in the lint span.
…done when no lint is produced, but has a few behavior changes. * Input to output inference on `dyn Trait` lifetimes is handled with a sufficient MSRV. * Elision on `dyn Trait` input lifetimes where the lifetime is used only once is suggested on all versions. * Lifetimes that are only used as a constraint on a single type are no longer detected. This is a regression. * A bunch of cases where the lints where prevented, but only a single lifetime was non-elidible now lint on remaining lifetimes.
Jarcho force-pushed the lifetime_ice_2 branch from b58863d to 336917b Compare Collaborator
| This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Based on #14702
This should generally be a perf improvement. The old implementation allocated a lot of things and then did multiple passes over the data. This only does a single pass allocating significantly less. It also bails out earlier in most cases.
Some behaviour changes:
dyn Trait + 'ais now elided when possible instead of completely bailing out of the lint.<'a, T: 'a>where'ais only used for the type outlives constraint. Theses lifetimes can be removed, but I'd rather handle that at the same time as handling outlives constraints on lifetimes.changelog: [
elidable_lifetime_names]: Lint whendyn Trait + 'acan be elided.changelog: [
needless_lifetimes] [elidable_lifetime_names]: Lint more cases when only some lifetimes can be elided.