add okta #402

metasean · 2019-07-09T19:05:48Z

This pull request adds support for Okta (specifically via "implicit flow").

codecov · 2019-07-09T19:22:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c2a8aee) to head (e48d592).
⚠️ Report is 798 commits behind head on dev.

Additional details and impacted files

@@ Coverage Diff @@ ## dev #402 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 2 2 ========================================= Hits 2 2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rgylling · 2019-07-29T15:47:30Z

Would be nice to have the ability to customize the okta url to utilize different dev modes.
ie https://${strategy.domain}.${strategy.oktaUrl}.com/oauth2/${serverId}/v1.
We use oktapreview.com

metasean · 2019-07-30T20:46:04Z

@rgylling - That was a super-simple config to add in. Please let me know how it works for you. 😀

rgylling · 2019-07-30T20:50:01Z

@metasean Awesome thanks for the quick fix. I was editing your source code to get it working locally so this will be much better!

runningrandall · 2019-10-22T15:07:48Z

Base branch conflicts have been resolved. Any chance we can get this merged?

runningrandall · 2019-11-14T21:55:58Z

Just following up on this.

smisaacs · 2020-01-13T05:37:58Z

can this get merged?

jaypeeig · 2020-02-26T04:14:57Z

interesting, I'm looking for this solution.. any chance this can be merged?

pi0 · 2020-03-03T16:04:51Z

build/config.gypi

@@ -0,0 +1,75 @@
+# Do not edit. File was generated by node-gyp's "configure" step


Why we need this file?

pi0 · 2020-03-03T16:07:33Z

docs/providers/okta.md

+
+2. Okta defaults to `/implicit/callback` instead of `callback`, so you _MUST_ ensure that you _EITHER_ have a corresponding callback component (i.e. `pages/implicit/callback.vue`) _OR_ that you change your Okta settings (Applications >> \<app\> >> General >> Logout redirect URIs).
+
+3. These instructions use the `@nuxtjs/dotenv` module extensively. This module and approach isn't strictly necessary, but is *_highly_* recommended, particularly if you are going to be using different Okta domains or server ids across environments (e.g. for different stages of CI).


I think highly recommended should have a reason and IMO it is not recommended to use a .env file, especially for CI/CD, flows but recommend using environment variables. Suggest to read The Twelve-Factor App

imo its useful for local dev it keeps you env variables isolated per project and someone can transfer their .env file for quick dev setup and it is easy to add or remove env variables.

@noobling I would be happy to discuss more but I think is out of the scope of this PR review and even if we finally end up recommended .env file, it should be module-wise not just for a specific provider that with the implicit flow doesn't even contain a server secret.

@pi0 I agree it is out of scope of this PR and should be removed.

From my understanding using a .env file is using environment variables. https://cli.vuejs.org/guide/mode-and-env.html#environment-variables.

Using separate .env files per environment/mode and adding them to .gitignore seems to work well foor CI/CD. I'm absolutely open to other methods for configuration of single-page apps. (although out of scope of this PR)

pi0 · 2020-03-03T16:09:56Z

docs/providers/okta.md

+### 1. Install dependencies
+`npm install @nuxtjs/auth @nuxtjs/axios @nuxtjs/dotenv`
+
+<details> 


We cannot merge PR with this!

pi0 · 2020-03-03T16:12:31Z

docs/providers/okta.md

+
+ auth: {
+ redirect: {
+ callback: process.env.REDIRECT_CALLBACK_URI, // optional


Maybe as a demo we can simply put defaults and comments here? + As of implicit flow, I don't see any point obscuring configuration with a dotenv file by default unless there is a deployment requirement to have different values for prod which is out of scope of this intro example or can be mentioned in footer to use either environment fallback like '/' || process.env.OKTA_REDIRECT_CALLBACK_API or node config package or dotenv

pi0 · 2020-03-03T16:13:10Z

docs/providers/okta.md

+
+## 4. Initialize your vuex store
+
+Create an `index.js` file in your `store` directory. An empty `index.js` is perfectly acceptable for this purpose.


It's a part of module installement not provider. Can be simply a note about ensure having store dir :)

pi0 · 2020-03-03T16:13:40Z

docs/providers/okta.md

+ - Okta does *_NOT_* provide a default logout redirect, therefore it *_MUST_* be set or users will get an error on logout. This module provides a default logout redirect value of `/`.
+
+- `auth.strategies.okta.url` is optional and defaults to `okta.com`.
+- 


extra line?

pi0 · 2020-03-03T16:15:28Z

lib/schemes/oauth2.js

 // Handle callbacks on page load
 const redirected = await this._handleCallback()

+ // TODO: determine if it is necessary to pull user info on EACH and EVERY page request?


Indeed it is. HTTP is stateless by nature! So for each SSR request, we need to either restore user from cookies (which implies transferring an object 2x per request) or fetching from remote.

Clarified config usage and removed doc requirements dotenv package. Also cleaned up a few comments.

runningrandall · 2020-03-05T18:04:43Z

Updated PR. Tests are passing now that I merge the right dev branch as opposed to master 🤦‍♂

ldiebold · 2020-03-11T04:44:40Z

Would it make more sense to wait until PKCE is implemented?
It seems sensible to start nudging people in that direction since there's less security holes.
https://oauth.net/2/grant-types/implicit/

The commit: #507

Is there any reason we shouldn't consider moving all default flows to PKCE where possible, once it's available?

smisaacs · 2020-04-02T18:21:49Z

any progress on this merge?

metasean added 2 commits July 9, 2019 12:53

add okta

9ae27fb

fix nexus dependencies in yarn.lock

6f6a1fa

metasean added 2 commits July 30, 2019 14:37

fix docs; add support for different okta url

e44547c

Merge branch 'dev' of github.com:nuxt-community/auth-module into okta

99461fb

runningrandall added 3 commits August 5, 2019 15:38

Fixing default for okta url. Also adding optional .env okta example.

7446090

Merge remote-tracking branch 'upstream/dev' into okta

efb13ca

fix lint issues

5dff385

pi0 requested changes Mar 3, 2020

View reviewed changes

runningrandall added 8 commits March 5, 2020 07:37

Merge remote-tracking branch 'upstream/master'

bd3bf14

Merge branch 'master' into okta

d11ea79

doc: updated docs per PR comments.

33307b1

Clarified config usage and removed doc requirements dotenv package. Also cleaned up a few comments.

delete: removing unecessary build/config.gypi file

b704551

fix: yarn.lock merge conflicts

bf4a7eb

fix: merge conflicts

8ce9f92

fix: auth.js, default.vue, storage.js to match master

fd35261

Merge remote-tracking branch 'upstream/dev' into okta

a73b042

remove uneeded directory 'p'

e48d592

pi0 force-pushed the dev branch from fd4d7b7 to 56d457a Compare December 18, 2020 23:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add okta #402

add okta #402

Uh oh!

metasean commented Jul 9, 2019

codecov bot commented Jul 9, 2019 •

edited

Loading

rgylling commented Jul 29, 2019

metasean commented Jul 30, 2019

rgylling commented Jul 30, 2019

runningrandall commented Oct 22, 2019 •

edited

Loading

runningrandall commented Nov 14, 2019

smisaacs commented Jan 13, 2020 •

edited

Loading

jaypeeig commented Feb 26, 2020

pi0 Mar 3, 2020

pi0 Mar 3, 2020

noobling Mar 5, 2020

pi0 Mar 5, 2020

runningrandall Mar 5, 2020

pi0 Mar 3, 2020

pi0 Mar 3, 2020

pi0 Mar 3, 2020

pi0 Mar 3, 2020

pi0 Mar 3, 2020

runningrandall commented Mar 5, 2020

ldiebold commented Mar 11, 2020

smisaacs commented Apr 2, 2020

Labels

8 participants

		@@ -0,0 +1,75 @@
		# Do not edit. File was generated by node-gyp's "configure" step


		2. Okta defaults to `/implicit/callback` instead of `callback`, so you _MUST_ ensure that you _EITHER_ have a corresponding callback component (i.e. `pages/implicit/callback.vue`) _OR_ that you change your Okta settings (Applications >> \<app\> >> General >> Logout redirect URIs).

		3. These instructions use the `@nuxtjs/dotenv` module extensively. This module and approach isn't strictly necessary, but is _highly_ recommended, particularly if you are going to be using different Okta domains or server ids across environments (e.g. for different stages of CI).


		## 4. Initialize your vuex store

		Create an `index.js` file in your `store` directory. An empty `index.js` is perfectly acceptable for this purpose.

add okta #402

Are you sure you want to change the base?

add okta #402

Uh oh!

Conversation

metasean commented Jul 9, 2019

codecov bot commented Jul 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

rgylling commented Jul 29, 2019

metasean commented Jul 30, 2019

rgylling commented Jul 30, 2019

runningrandall commented Oct 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

runningrandall commented Nov 14, 2019

smisaacs commented Jan 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jaypeeig commented Feb 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

runningrandall commented Mar 5, 2020

ldiebold commented Mar 11, 2020

smisaacs commented Apr 2, 2020

Labels

8 participants

codecov bot commented Jul 9, 2019 •

edited

Loading

runningrandall commented Oct 22, 2019 •

edited

Loading

smisaacs commented Jan 13, 2020 •

edited

Loading