Docs: Docker 部署镜像添加 latest tag #3787
Open
+1 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1.使用 'if' 条件，确保此步骤仅在推送到 'main' 分支时运行，避免了 'enable' 属性的错误。2.确保只有在标签生成步骤成功运行时（即在 main 分支 push 时），才执行构建和推送。 3.docker image推送时增加latest标签
AhsokaTano26 changed the title 
Contributor
| 🚀 Deployed to https://deploy-preview-3787--nonebot2.netlify.app |
Member
| action 的触发条件写的就是当 push tag 的时候才会执行啊，你这个 if 有什么意义？ |
Contributor Author
| 具体细节有点忘了，但这个是增加latest标签是运行报错的解决方案 |
Contributor Author
 |
Member
| 你的 tag 是打在了非 master branch 上？正确用法应该是 另外我觉得你这个属于自定义行为了，不应该放到文档里。 |
Contributor Author
| 我思考的是有latest标签，就不需要每次去查看hash值了。不过确实可以自己修改，那就close？ |
Member
| action会把你 push tag 的版本打到镜像上，也不需要你看 hash 啊 |
Contributor Author
| 是拉取的时候，因为我实践中机子没公网ip，实现不了action的自动拉取构建，每次需要去dockerhub查看 |
Member
| 那你直接加上这个 latest tag 就可以了 |
yanyongyu changed the title Contributor Author
| OK，那我等会把两个判断删了 |
Removed conditional checks for generating tags and building/publishing.
Member
| 你有试过这么写对吗 🤔 不需要 enable 参数了吗？ |
Contributor Author
| 我这会试试 |
Contributor Author
| 刚进行测试，是可用的 |
Member
| 你这测试的是 push branch 不是 tag？另外文档同步更新一下其他几个版本的文件 |
Contributor Author
| 测试的是 push branch，同步更新我抽空搞 |
Member
| @AhsokaTano26 测试过 push tag 了吗？更新还没有同步。 |
Contributor Author
| 十分抱歉，最近考试周，可能得等到1月5日考完才能继续测试 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
1.使用 'if' 条件，确保此步骤仅在推送到 'main' 分支时运行，避免了 'enable' 属性的错误。
2.确保只有在标签生成步骤成功运行时（即在 main 分支 push 时），才执行构建和推送。
3.docker image推送时增加latest标签