Skip to content

Conversation

@sagudev
Copy link
Contributor

@sagudev sagudev commented Oct 6, 2025

See linebender/peniko#143 for more info.

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be willing to update the lib.rs lint sets to v4 whilst we're here - see https://linebender.org/wiki/canonical-lints/? The doc_auto_cfg is part of the lint set.

I'd be very surprised if that added any new warnings.

@sagudev
Copy link
Contributor Author

sagudev commented Oct 6, 2025

Would you be willing to update the lib.rs lint sets to v4 whilst we're here - see https://linebender.org/wiki/canonical-lints/? The doc_auto_cfg is part of the lint set.

It's already done:
slika

@DJMcNab
Copy link
Member

DJMcNab commented Oct 6, 2025

Hmm, I clearly didn't express myself well enough - I was trying to ask you to update the lib.rs lint sets in this repository to v4, not the ones on the website. That was already done in linebender/linebender.github.io#123.
The lines which you're editing are part of the lint set block of this PR; they are outside the // END LINEBENDER LINT SET because of how rustfmt handles comments, binding them closely to the next attribute.

https://github.com/sagudev/color/blob/c34cb91626e99b57bd6e0e585cdc27dbba4856e8/color/src/lib.rs#L77-L84
Shows that this PR is still on v1, not v4.

Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
@sagudev sagudev changed the title chore: replace obsolete doc_auto_cfg feature with doc_cfg chore: update to latest linebender set Oct 6, 2025
@sagudev sagudev requested a review from DJMcNab October 6, 2025 11:33
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@DJMcNab DJMcNab changed the title chore: update to latest linebender set chore: update to latest lint set Oct 6, 2025
@sagudev sagudev added this pull request to the merge queue Oct 6, 2025
Merged via the queue into linebender:main with commit ea23eec Oct 6, 2025
16 checks passed
@sagudev sagudev deleted the fix-ci branch October 6, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants