Skip to content

Conversation

@jeetburman
Copy link
Contributor

This PR addresses issue #602 by renaming the existing red palette to magenta and introducing a new true red palette.

  • Renamed existing red palette to magenta (pinkish-red hues)
  • Created new red palette based on #F91313 (notification error color)
  • Updated palette.ts to use magenta for error backgrounds
  • New red palette provides true red colors for error states

Resolves #602

Notes for Reviewers

This PR fixes #602

The existing red palette contained pinkish-magenta hues (e.g., #ff385c, #FFB3B9). This has been renamed to magenta for semantic accuracy. A new red palette has been created using #F91313 as the base color, which is already used for notification errors and provides true red colors.

Changes are backward compatible - the magenta palette retains all the previous red values, and components using error states now benefit from more accurate red colors.

Signed commits

  • Yes, I signed my commits.
@jeetburman
Copy link
Contributor Author

jeetburman commented Dec 13, 2025

@jeetburman
Copy link
Contributor Author

jeetburman commented Dec 14, 2025

@saurabhraghuvanshii ,
I've updated the magenta palette to proper magenta (purple-pink) shades:

  • magenta[70]: #FFF0FA (was #FFF0F0)
  • magenta[60]: #FFB3E6 (was #FFB3B9)
  • magenta[50]: #FF66CC (was #FF6179)
  • magenta[40]: #E600AC (was #ff385c)
  • magenta[30]: #B30086 (was #B3153D)
  • magenta[20]: #800060 (was #8C0a2F)
  • magenta[10]: #4D0039 (was #660624)

The magenta palette now uses true purple-pink colors instead of rose-red. The red palette remains unchanged with true red colors based on #F91313.

@saurabhraghuvanshii
Copy link
Contributor

@jeetburman check shades here https://maketintsandshades.com/#colors=B32700&hashtag=0&steps=10 and issue is to rename exitsing shades without removing old shades because we are using that shades everywhere so it will break our current setup

@jeetburman
Copy link
Contributor Author

@jeetburman check shades here https://maketintsandshades.com/#colors=B32700&hashtag=0&steps=10 and issue is to rename exitsing shades without removing old shades because we are using that shades everywhere so it will break our current setup

I understand. Thank you for clarifying. I will make the necessary changes..

@saurabhraghuvanshii
Copy link
Contributor

@jeetburman I would suggest leave this issue solve other open issue. Because minor change can break many websites

@saurabhraghuvanshii
Copy link
Contributor

If you still trying to solve you have to go with all meshery and layer5 repo to verify your changes

@kishore08-07
Copy link

@jeetburman
Thank you for your contribution!
Let's discuss this during the website call today at 6:30 PM IST | 8 AM CT
Add it as an agenda item to the meeting minutes, if you would :)

@jeetburman
Copy link
Contributor Author

@jeetburman Thank you for your contribution! Let's discuss this during the website call today at 6:30 PM IST | 8 AM CT Add it as an agenda item to the meeting minutes, if you would :)

I have added my discussion topic in the agenda items...

@nebula-aac
Copy link
Contributor

ack, reviewing now

@jeetburman jeetburman force-pushed the fix/rename-red-palette-to-magenta-add-true-red branch from 937e6b8 to 6600081 Compare December 19, 2025 14:29
@jeetburman
Copy link
Contributor Author

I have freshly made the changes this time. I preserved the original red pallette and add two new pallettes... Magenta and Crimson. @saurabhraghuvanshii @nebula-aac , let me know if any further change is required.

- Add true magenta palette (purple-pink) with base color #E600AC - Add crimson palette (pure red) with base color #F91313 - Preserve existing red palette for backward compatibility - Export both new palettes in colors index Closes layer5io#602 Signed-off-by: Jeet Burman <jeetburrman@gmail.com>
@jeetburman jeetburman force-pushed the fix/rename-red-palette-to-magenta-add-true-red branch from 1ac2491 to 6d7a97c Compare December 19, 2025 14:36
@saurabhraghuvanshii
Copy link
Contributor

@jeetburman lgtm!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants