Add a connection status hook (discussion required) #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Problem
I want to be able to determine the current status of my connection to Reverb. As it stands there isn't currently a way to reliably retrieve this status.
Proposed Solution
I have added a
useConnectionStatushook that returns the current status, fetching it from the existing Pusher and Socket.IO libraries behind the scenes.Notes
I am not currently sold on the return values as strings, but I couldn't come up with anything better that clearly represented the various states. I am very open to alternative suggestions; I just wanted to get something out there so that we could start the discussion.