[535] Implement basic support for GenQuery2 #555
Conversation
stsnel force-pushed the add-basic-genquery2-support branch from ff51694 to 352ef9c Compare 
| Thanks for the contribution. We'll review and share our thoughts. |
alanking left a comment
alanking left a comment There was a problem hiding this comment.
I had a few suggestions/comments. I would have suggested adding more tests, but the existing tests basically exercise the interface in this client, so I don't think it would add anything beyond just testing the API (which we do plenty of in the main repo).
Nice work!
stsnel force-pushed the add-basic-genquery2-support branch from 352ef9c to e239307 Compare 
Thank you for the feedback! |
stsnel force-pushed the add-basic-genquery2-support branch 3 times, most recently from dac3a60 to cb8230d Compare 
korydraughn left a comment
korydraughn left a comment There was a problem hiding this comment.
Looks good to me.
Let's get an approval from @alanking and @d-w-moore before adding the pound.
alanking left a comment
alanking left a comment There was a problem hiding this comment.
Yes, let's make sure @d-w-moore is okay with it and I think we'll be good to go.
stsnel force-pushed the add-basic-genquery2-support branch from cb8230d to 6b67b98 Compare 4 participants
Here's a draft for an initial version of GenQuery2 support (issue 535)