feat: Add Book Talks carousel to the homepage with new data fetching … #11624
+152 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
mekarpeles requested changes Dec 25, 2025
Member
mekarpeles left a comment
mekarpeles left a comment There was a problem hiding this comment.
Thank you for working on this!
Since these images are more horizontal (wide) than vertical (tall), we likely want to show fewer (e.g. just 3).
We also will want to show the title and the date (as otherwise it's unclear what the video is).
Furthermore, we'll want to move the css out of inline styles and into the correct files in `static/css
Comment on lines +7 to +19
| <style> | ||
| .carousel-section--book-talks .book_carousel__book { | ||
| height: 200px; | ||
| background: #000; | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: center; | ||
| overflow: hidden; | ||
| border-radius: 4px; | ||
| border: 1px solid #ddd; | ||
| width: 100%; | ||
| margin: 0 auto; | ||
| } |
Member
There was a problem hiding this comment.
Inline styles should be moved to static/css files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #11617
Feature Requested
Add new "Book Talks" carousel to homepage using archive.org API.
Screenshot
Changes