Add new read() method that sets read buffer size #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
New read(UsbReadCallback, int) method added that takes additional parameter which defines size of the read buffer when communicating asynchronously.
Owner
| @tihomirleka Thanks for the PR. I will check it out as soon as possible |
| Think this could be merged and released if it looks good? The 16kb buffer size with callbacks is a showstopper for me. If this isn't releasable, is there a workaround to change the size of the buffer once the callback is set? I looked but didn't see anything. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
New read(UsbReadCallback, int) method added that takes additional
parameter which defines size of the read buffer when communicating
asynchronously.