fix(ApiExplorer): SubstitutedType have invalid property setter #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| @dotnet-policy-service agree |
AndreaCuneo force-pushed the bugfix/SubstituteTypeInvalidPropertySetter branch from 27ac7c3 to 41f8cda Compare Contributor Author
| @commonsensesoftware can you please take a look. is a 1 line change plus tests. |
| This works! I implemented the fix and published a new package version to our internal feeds, and now we can upgrade our odata projects to at least Swashbuckle 9. @AndreaCuneo thanks a million! Hopefully this gets merged to mainline soon |
Collaborator
commonsensesoftware left a comment
commonsensesoftware left a comment There was a problem hiding this comment.
Minor feedback, but otherwise looks good.
src/Common/src/Common.OData.ApiExplorer/OData/DefaultModelTypeBuilder.cs Show resolved Hide resolved
src/Common/test/Common.OData.ApiExplorer.Tests/OData/DefaultModelTypeBuilderTest.cs Show resolved Hide resolved
src/Common/test/Common.OData.ApiExplorer.Tests/OData/DefaultModelTypeBuilderTest.cs Outdated Show resolved Hide resolved
src/Common/test/Common.OData.ApiExplorer.Tests/OData/DefaultModelTypeBuilderTest.cs Outdated Show resolved Hide resolved
AndreaCuneo force-pushed the bugfix/SubstituteTypeInvalidPropertySetter branch from 41f8cda to 6805c37 Compare The PropertySetter of the SubstitutedType have 0 parameters: they had the same signature of the Getter. resolves: dotnet#1104
AndreaCuneo force-pushed the bugfix/SubstituteTypeInvalidPropertySetter branch from 6805c37 to 1ae3d96 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix(ApiExplorer): SubstitutedType have invalid property setter
Description
The PropertySetter of the SubstitutedType properties have 0 parameters: they had the same signature of the Getter.
Fixes #1104