Fix toggling optional rule groups #1089
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hello. Will this be merged? Optional rules are very useful. Currently its cumbersome to open the ldtk as text file to toggle the isOptional value. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix a regression introduced in 225a891
I simply swapped conditional branches, and built/tested via
npm run pack-linux-x86and it seems to have fixed the regressioncloses #1059
also, apologies if this should be merged into
master, not completely sure on the repository setup/regular practices.P.S. Thanks so much for the awesome tool!! :)