Change ConditionallySelectable supertrait #137
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
To resolve #94, removes the
Copysupertrait bound onConditionallySelectable, replacing it withSizedinstead.It turns out the bound is only used in the default implementation of
ConditionallySelectable::conditional_swap, and is easy to replace by slightly changing that default implementation.Removing this supertrait bound is arguably a breaking change since it means types which impl
ConditionallySelectablecan no longer be assumed to beCopy, so also bumps the version to3.0.0-pre.Alternative to #118, #136