Skip to content

Conversation

@dprotaso
Copy link

@dprotaso dprotaso commented Sep 4, 2025

No description provided.

Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
@dprotaso dprotaso force-pushed the knative-logo-updates branch from 3bee15f to c3398d5 Compare September 4, 2025 16:34
@dprotaso
Copy link
Author

dprotaso commented Sep 4, 2025

cc @aliok @evankanderson @matzew (Knative Steering)

@aliok
Copy link
Member

aliok commented Sep 5, 2025

Looks good to me.

I thought there might be links to existing images and looked for ways to find those references. I wasn't able to find a good way.

@aliok
Copy link
Member

aliok commented Sep 5, 2025

/lgtm

Copy link

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVGs don't quite seem right. Let me know if you end up wanting help.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On GitHub, the font is rendering bolder than the .png and with an incorrect bounding box. I think it's picking the wrong font. You may need to embed the font into the SVG using:

<style> @import url('https://fonts.cdnfonts.com/css/satoshi'); </style> 

or:

<style> @font-face { font-family: 'Satoshi'; font-style: normal; font-weight: 500; src: local('Satoshi'), url('https://fonts.cdnfonts.com/s/85546/Satoshi-Medium.woff') format('woff'); } </style> 

(Assuming you're using medium weight Satoshi)

or go into Inkscape and use "Convert to path", which will replace the text + font combination with a set of curves that match the text.

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, just wanted to check in on this PR as it appears to have stalled a bit. @dprotaso, do you have time to look into @evankanderson's comments?

@evankanderson
Copy link

Dave, do you want me to PR those changes to your branch?

@dprotaso
Copy link
Author

dprotaso commented Oct 28, 2025 via email

@nate-double-u
Copy link
Member

#608 won't actually affect this PR, I thought it might, but this PR just affects the logos.

evankanderson and others added 2 commits October 30, 2025 15:22
Signed-off-by: Evan Anderson <evan@custcodian.dev>
@dprotaso
Copy link
Author

dprotaso commented Nov 7, 2025

OK - the svg now has the embedded font

@nate-double-u
Copy link
Member

Thanks for the update @dprotaso; however, there are still some updates I’d like to ask for. The SVG files appear to be cut off on the right, and the PNG files appear to have a slight outline on the text:

cncf-artworkexamplesincubating md at knative-logo-updates · dprotasocncf-artwork
@dprotaso
Copy link
Author

dprotaso commented Nov 9, 2025

@nate-double-u interesting mine shows up as

Screenshot 2025-11-08 at 10 44 31 PM

Where are you viewing that?

@evankanderson do you know what might be happening with the font embedding?

@nate-double-u
Copy link
Member

I'm using the GitHub UI. My first screen cap was using my ipad, which put them on a dark background which made it easier to see the haloing, but you can see the cutoff better here:


Screenshot 2025-11-08 at 8 21 24 PM

@evankanderson
Copy link

Interesting, I don't see the cutoff (Android) Screenshot_20251109-015323.GitHub.png

@nate-double-u nate-double-u dismissed their stale review November 10, 2025 18:42

OK, I’ll dismiss my request for changes now in case someone is able to merge this before i can do another check. i’ll take another look and try to get to the bottom of this later in the evening.

Copy link
Member

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I ran the SVGs through the https://autocrop.cncf.io/ tool, and it says that there are PNGs embedded in the SVG files. This would explain the weird cropping I'm seeing (and the varibility I'm seeing between browsers and computers).

Could you please update the files to be pure SVG, and test using the autocrop.cncf.io site?

@nate-double-u
Copy link
Member

@dprotaso, I'm not sure why it wasn't added initially, but here's the pre-submission checklist that usually gets added to a PR (it has info about the autocrop tool):

Pre-submission checklist:

If you're adding a new project to the repo, please confirm each of these actions has been completed:

[ ] Artwork is supplied in both PNG and SVG formats.
[ ] SVGs are real vector-based files. Test and optimize them at https://autocrop.cncf.io/ before submitting.
[ ] Artwork includes 3 layouts: horizontal (landscape), stacked, and icon.
[ ] At least 3 versions of the artwork are provided: color, black, and white.
[ ] Files follow the existing repo folder and naming conventions.
[ ] The correct examples/file.md is updated with a section for the logos added, in A-Z order.
[ ] A link to the new logo section is added to the main README.md, in A-Z order.

Note: Updates to this repo require two approvals to be merged in. One from a CNCF staff member, and the other from a project maintainer whose project's artwork is being updated. We can bypass branch protections for PRs made by maintainers.

@evankanderson
Copy link

So I ran the SVGs through the https://autocrop.cncf.io/ tool, and it says that there are PNGs embedded in the SVG files. This would explain the weird cropping I'm seeing (and the varibility I'm seeing between browsers and computers).

Could you please update the files to be pure SVG, and test using the autocrop.cncf.io site?

There aren't PNGs embedded in the SVG file, but there is a font embedded. I wonder if autocrop is getting confused between the two.

@evankanderson
Copy link

Autocrop says:

Fails with an error on SVGs that contain a or element since the text will not render reliably if the specified fonts are not installed (instead, you can convert the text to an image so that it will reliably render anywhere)

This does contain a text, but it also includes the font.

@nate-double-u
Copy link
Member

I'll ask the LF design team to help out with this in the new year. 🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants