- Notifications
You must be signed in to change notification settings - Fork 372
include 'Knative' project name in horizontal and stacked artwork #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
3bee15f to c3398d5 Compare | cc @aliok @evankanderson @matzew (Knative Steering) |
| Looks good to me. I thought there might be links to existing images and looked for ways to find those references. I wasn't able to find a good way. |
| /lgtm |
evankanderson left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SVGs don't quite seem right. Let me know if you end up wanting help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On GitHub, the font is rendering bolder than the .png and with an incorrect bounding box. I think it's picking the wrong font. You may need to embed the font into the SVG using:
<style> @import url('https://fonts.cdnfonts.com/css/satoshi'); </style> or:
<style> @font-face { font-family: 'Satoshi'; font-style: normal; font-weight: 500; src: local('Satoshi'), url('https://fonts.cdnfonts.com/s/85546/Satoshi-Medium.woff') format('woff'); } </style> (Assuming you're using medium weight Satoshi)
or go into Inkscape and use "Convert to path", which will replace the text + font combination with a set of curves that match the text.
nate-double-u left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, just wanted to check in on this PR as it appears to have stalled a bit. @dprotaso, do you have time to look into @evankanderson's comments?
| Dave, do you want me to PR those changes to your branch? |
| Sure if that’s easier for you to do …On Tue, Oct 28, 2025 at 16:47 Evan Anderson ***@***.***> wrote: *evankanderson* left a comment (cncf/artwork#587) <#587 (comment)> Dave, do you want me to PR those changes to your branch? — Reply to this email directly, view it on GitHub <#587 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAERARNEWDIFKLSOAU2ET33Z7I5NAVCNFSM6AAAAACFURQ7PCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTINJYGQZDANZYGY> . You are receiving this because you were mentioned.Message ID: ***@***.***> |
| #608 won't actually affect this PR, I thought it might, but this PR just affects the logos. |
Signed-off-by: Evan Anderson <evan@custcodian.dev>
Add reference to Satoshi font
| OK - the svg now has the embedded font |
| Thanks for the update @dprotaso; however, there are still some updates I’d like to ask for. The SVG files appear to be cut off on the right, and the PNG files appear to have a slight outline on the text: |
| @nate-double-u interesting mine shows up as Where are you viewing that? @evankanderson do you know what might be happening with the font embedding? |
| You can also see a "deploy preview" here: https://github.com/dprotaso/cncf-artwork/blob/knative-logo-updates/examples/incubating.md#knative-logos |
OK, I’ll dismiss my request for changes now in case someone is able to merge this before i can do another check. i’ll take another look and try to get to the bottom of this later in the evening.
nate-double-u left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I ran the SVGs through the https://autocrop.cncf.io/ tool, and it says that there are PNGs embedded in the SVG files. This would explain the weird cropping I'm seeing (and the varibility I'm seeing between browsers and computers).
Could you please update the files to be pure SVG, and test using the autocrop.cncf.io site?
| @dprotaso, I'm not sure why it wasn't added initially, but here's the pre-submission checklist that usually gets added to a PR (it has info about the autocrop tool):
|
There aren't PNGs embedded in the SVG file, but there is a font embedded. I wonder if autocrop is getting confused between the two. |
| Autocrop says:
This does contain a |
| I'll ask the LF design team to help out with this in the new year. 🎄 |




No description provided.