Skip to content

Conversation

@tdybda17
Copy link

No description provided.

@auvipy auvipy requested review from auvipy and Copilot and removed request for Copilot May 12, 2025 05:59
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change will also need some unit tests to verify it and to avoid any regression

@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.94%. Comparing base (d78ba7a) to head (236036a).

Additional details and impacted files
@@ Coverage Diff @@ ## main #887 +/- ## ========================================== + Coverage 87.62% 87.94% +0.32%  ========================================== Files 32 32 Lines 1010 1012 +2 Branches 81 104 +23 ========================================== + Hits 885 890 +5  + Misses 107 104 -3  Partials 18 18 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@cclauss
Copy link
Contributor

cclauss commented May 12, 2025

pre-commit failures:

flake8...................................................................Failed - hook id: flake8 - exit code: 1 django_celery_beat/schedulers.py:381:80: E501 line too long (121 > 79 characters) t/unit/test_schedulers.py:1459:1: E303 too many blank lines (3) t/unit/test_schedulers.py:1469:80: E501 line too long (80 > 79 characters) t/unit/test_schedulers.py:1473:80: E501 line too long (84 > 79 characters) t/unit/test_schedulers.py:1494:80: E501 line too long (84 > 79 characters) 
@cclauss
Copy link
Contributor

cclauss commented May 12, 2025

Please rebase to fix the linter failure.

@auvipy
Copy link
Member

auvipy commented May 18, 2025

@alirafiei75 can you check this locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants