a handful of fixes and improvements found while testing this branch #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits August 10, 2019 02:57
…r when running ln -s by adding -f in Makefile, combine two layers of Dockerfile and fix typo of pugring.gpg~ Signed-off-by: Linux Ninja <linuxninja@bryangay.com>
…vailable CPU cores, overwrite existing file Signed-off-by: Linux Ninja <linuxninja@bryangay.com>
shibumi reviewed Aug 10, 2019
Contributor
| Sorry for the late reply. I took the time to review this and it works. I was wondering if we would want to parametrize the number of cores provided to |
alerque approved these changes Apr 23, 2020
Member
| @SantiagoTorres sorry for reviving this: According to xz's man page: So actually this PR is already using as much cores as possible. |
shibumi approved these changes Jul 17, 2020
Contributor
| yes, I don't mean to "make it use all cores" I mean "allow us to say how many cores we want to use (hence the parameter) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.