Fix TX queue overflow, improve PHY initialization and cleanup in bdx driver #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
the nr_frags variable after adding a fragment for short packets (<60 bytes). This fix increments nr_frags accordingly to keep tx_level consistant, preventing overflow warnings. The pci_free_irq_vectors() function does not free individual IRQs and leaves procfs entries behind causing wanrings about non-empty directories.Consequently, free_irq() has been added so that driver removal does not complaint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR addresses several issues and improvements in the bdx driver:
Fix TX queue overflow
Correct handling of nr_frags in bdx_tx_transmit() to properly account for additional fragments added for short packets (< 60 bytes), preventing priv->tx_level overflow warnings.
Fix PHY initialization
Corrected the bdx_phy_init() function to detect and register PHY devices with MDIO bus different from 1.
Fix driver removal warning about IRQ
Fixed IRQ cleanup routines to prevent warning during driver unload.
These changes increase driver stability and hardware compatibility, especially for PHY handling and TX packet transmission with short packets.