Skip to content

[Draft] use current metrics for adaptive circuit breaker reporting #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
adriangudas wants to merge 1 commit into
base: pid-take-2
Choose a base branch
from
Draft

[Draft] use current metrics for adaptive circuit breaker reporting #913

adriangudas wants to merge 1 commit into from

Conversation

@adriangudas
Copy link

@adriangudas adriangudas commented Dec 8, 2025 •
edited
Loading

Use current metrics instead of last window for the error state transition message. This way, we get an up-to-date understanding of the error rate at the moment of transition.

This is also missing last_error_message and error_last_at to be parity with legacy.

On a 100% error rate spike, now prints:

I, [2025-12-07T18:53:39.989926 #98450] INFO -- : [Semian::AdaptiveCircuitBreaker] State transition from closed to open. success_count= error_count= rejected_count= rejection_rate=87.64% error_rate=98.38% ideal_error_rate=1.0% integral=9.7378 name="my_service"
@adriangudas adriangudas changed the base branch from main to pid-take-2 December 8, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@adriangudas