[Fixes #13831] Supported additional EXIF metadata extraction from image Documents and refactor of DOCUMENT_TYPE_MAP and DOCUMENT_MIMETYPE_MAP

[sijandh35]

Fixes #13831

Updates:

• Move tif and tiff from archives to image.
• Updated exif extraction code.
• Refactor DOCUMENT_TYPE_MAP and DOCUMENT_MIMETYPE_MAP.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
• New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[gemini-code-assist]

Summary of Changes

Hello @sijandh35, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the handling of image documents by enhancing EXIF metadata extraction capabilities and refining the internal document type mapping. The changes ensure that more comprehensive metadata, including detailed Exif and GPS information, is correctly retrieved from images, while also streamlining the classification of various image file types within the system.

Highlights

• Enhanced EXIF Metadata Extraction: The system now extracts a broader range of EXIF metadata, including detailed Exif IFD and GPS IFD information, from image documents, providing richer contextual data.
• Refactored Document Type Mapping: The DOCUMENT_TYPE_MAP has been updated to correctly classify tif and tiff files as images and remove several less common or redundant image extensions, improving accuracy.
• Improved Image Type Detection: The logic for identifying image documents for EXIF processing now leverages a more robust doc.is_image property instead of relying solely on file extensions, enhancing reliability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances EXIF metadata extraction from image documents and refactors the DOCUMENT_TYPE_MAP. The changes in geonode/documents/exif/utils.py are a significant improvement, leveraging modern Pillow APIs to robustly extract more EXIF data, including from specific IFDs like Exif and GPS. However, the refactoring of DOCUMENT_TYPE_MAP in geonode/documents/enumerations.py introduces an issue by removing several valid image file extensions (bm, bmp, fif, jpe). This would prevent EXIF extraction from these image types, as the logic now correctly relies on doc.is_image, which uses this map. I have provided a suggestion to restore these extensions while keeping the other beneficial changes.

[gemini-code-assist]

While refactoring DOCUMENT_TYPE_MAP, several image formats like bm, bmp, and jpe were removed. This appears to be a regression, as it will prevent EXIF metadata extraction for these file types since the logic now relies on doc.is_image. This also introduces an inconsistency with DOCUMENT_MIMETYPE_MAP, where these extensions are still defined.

I suggest adding these image types back to ensure continued support. The change to correctly classify tif and tiff as image is correct and has been preserved in the suggestion.

 "xls": "text", "xlsx": "text", "xml": "text", "bm": "image", "bmp": "image", "dwg": "archive", "dxf": "archive", "fif": "image", "gif": "image", "jpg": "image", "jpe": "image", "jpeg": "image", "png": "image", "tif": "image", "tiff": "image", "pbm": "archive", "odp": "presentation", "ppt": "presentation"

[sijandh35]

Now DOCUMENT_MIMETYPE_MAP also has been updated(by removing: bm, bmp , fif and jpe type) to make it consistent with DOCUMENT_TYPE_MAP.

[codecov]

Codecov Report

❌ Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.16%. Comparing base (3ed2514) to head (b882603).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@ ## master #13835 +/- ## =========================================== + Coverage 52.15% 74.16% +22.01%  =========================================== Files 944 944 Lines 56335 56339 +4 Branches 7626 7627 +1 =========================================== + Hits 29380 41786 +12406  + Misses 25588 12875 -12713  - Partials 1367 1678 +311 

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.