WP_Http: add support for headers split over multiple lines

[wnorris]

rfc2616 section 2.2 defines rules for splitting HTTP headers across multiple lines. This patch adds support for this to WP_Http.

[ryan]

DD32, jacobsantos, review? Need to lose the CamelCase in the var names. WP uses underscores.

[Denis-de-Bernardy]

Updated the patch to use underscores, and added a check on the header array's size.

@Ryan: His point is valid. I've used similar code to parse email headers in a separate app a few years back.

[DD32]

Sorry, Didnt see this ticket for review.

First code chunk: (status location changed)

• Not sure if this is going to work correctly with proxies, I think it was in the loop for a reason, To catch the last status header rather than the first one (Which is often a proxy header)

Second code chunk: (Multiline headers)

• Looks good to me, Pretty sure it was just something jacob didnt feel like doing, no technical reason as such
• I'd get rid of the temp var myself, and use if ( in_array($headers[$i]{0}, array(' ', "\t")) ) { instead, but thats just me. s/$c/$headers[$i]{0}/g is another option
• How's the trimming going to affect headers which have whitespace? (Or is that against spec?

  Header: Some Value.. Now 4 spaces: Now some more text 

  • It might be better to base that off a .= substr($string, 1) ?

[Denis-de-Bernardy]

needs a new patch then

[hakre]

new patch. the RFC is not _that_ complex. i just decided to go into the normalization of the headers upfront before splitting. that makes handling easier afterwards.

i was very strict to the rfc and therefore changed to propper CRLF tolerant parsing. that might be questionable but since this ticket was dedicated to the RFC voila.

unfolding upfront makes much more sense to me. just for the quote from 2.2:

HTTP/1.1 header field values can be folded onto multiple lines if the continuation line begins with a space or horizontal tab. All linear white space, including folding, has the same semantics as SP. A recipient MAY replace any linear white space with a single SP before interpreting the field value or forwarding the message downstream.

because DD32 questioned the location status logic i kept it out.

[hakre]

The RFC is not that complex. (Fixed)

[hakre]

regex was broken in patched. fixed.

[Denis-de-Bernardy]

+1

[ryan]

wnorris, do these patches work for you?

[Denis-de-Bernardy]

@ryan: in case wnorris doesn't reply back soon, I ran into similar issues in a separate piece of php software. I needed to parse emails and stick their content into a blog.

If you open an email's headers, you'll occasionally see things such as:

header name: values go a first line

more values go on a second line

the patch deals with those cases.

[hakre]

The RFC is not that complex. (RegEx Fixed)

[hakre]

now this time the broken regex was fixed. forgotten regex delimiters have been added. rest of patch unchanged.

[ryan]

(In [11351]) Support headers split over multiple lines. Props hakre, Denis-de-Bernardy, wnorris. fixes #9395

[Lazy79]

Warning: Wrong parameter count for str_replace() in /opt/lampp/htdocs/web11/html/wp-includes/http.php on line 402

Warning: Wrong parameter count for str_replace() in /opt/lampp/htdocs/web11/html/wp-includes/http.php on line 402

Warning: Wrong parameter count for str_replace() in /opt/lampp/htdocs/web11/html/wp-includes/http.php on line 402

After Updating i got these lines in the Dashboard - after a reload, they are gone.

I am not sure if i am doing right in posting it here.. please be patient :)

[ryan]

(In [11355]) Fix bad call to str_replace. see #9395

[hakre]

Related: #13513

This adds additional test combinations to the workflow that tests the build process that run on Node.js versions 22 and 24.

22.x is the Active LTS version for Node.JS and scheduled to become Maintenance LTS in October when 24.x graduates to the Active LTS. Testing against these versions will help spot any potential compatibility issues that come up and can make upgrading in the future.

This pull request tests only the Core build process with these versions. This is an alternate approach to #9395.

This results in 12 additional jobs in the test matrix. These new jobs will only run within wordpress-develp, not within forks.

Trac ticket: