Make WordPress Core

Opened 8 months ago

Closed 4 days ago

Last modified 4 days ago

#63171 closed task (blessed) (fixed)

Update/Audit NPM Dependencies for 6.9

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 6.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

Previously:

Change History (17)

This ticket was mentioned in PR #8706 on WordPress/wordpress-develop by @debarghyabanerjee.


7 months ago
#1

  • Keywords has-patch added

Trac Ticket: Core-63171

#2 @desrosj
5 months ago

In 60348:

Build/Test Tools: Commit changes to built theme files for PRs.

When there are uncommitted changes to versioned files in default themes, the theme testing workflow will now store the patch file required for the changes to be committed back to the pull request.

See #63170, #63171.

#3 @desrosj
5 months ago

In 60349:

Build/Test Tools: Create groups for bundled theme Dependabot PRs.

Follow up to [60347].

See #63170, #63171.

#4 @desrosj
5 months ago

In 60350:

Build/Test Tools: Only check for changes to versioned files once.

Because the theme testing workflow now stores a patch file with changes to versioned files, there is no need for the separate workflow to run and do the same when only theme files are updated.

Follow up to [60348].

See #63170, #63171.

This ticket was mentioned in PR #9207 on WordPress/wordpress-develop by @johnbillion.


4 months ago
#5

e2e-test-utils was replaced with e2e-test-utils-playwright in https://core.trac.wordpress.org/ticket/59517 and is no longer needed. This removes a few dependencies but we can't get rid of Puppeteer just yet because grunt-contrib-qunit still depends on it for the QUnit tests.

#6 @johnbillion
4 months ago

In 60429:

Build/Test Tools: Remove the e2e-test-utils package which is no longer used.

This package was superseded by e2e-test-utils-playwright in #59517.

See #63171

#8 @jorbin
4 weeks ago

In 61011:

Build/Test Tools: Update caniuse data.

Browsers data (caniuse-lite) is 9 months old, so make it more up to date before beta 1.

See #63171.

This ticket was mentioned in PR #10465 on WordPress/wordpress-develop by @desrosj.


11 days ago
#9

Trac ticket: Core-63171

This ticket was mentioned in Slack in #core by welcher. View the logs.


5 days ago

#11 @desrosj
5 days ago

  • Owner set to desrosj
  • Status changed from new to assigned

This ticket was mentioned in PR #10501 on WordPress/wordpress-develop by @desrosj.


4 days ago
#12

This updates all npm dependencies for default themes except the following in Twenty Twenty-One:

  • sass: Updating this results in duplicate class declarations with just inline comment blocks.
  • stylelint-related packages - causing unexpected changes to file indentation.
  • eslint is only updated to the highest 8.x version (9.x is not yet supported by WordPress-related packages, see https://github.com/WordPress/gutenberg/pull/65648).

Trac ticket: Core-63171.

#13 @desrosj
4 days ago

In 61205:

Build/Test Tools: Update devDependencies.

This updates the following devDependencies:

  • @playwright/test from 1.50.1 to 1.56.1.
  • @pmmmwh/react-refresh-webpack-plugin from 0.5.15 to 0.6.1.
  • autoprefixer from 10.4.20 to 10.4.22.
  • chalk from 5.4.1 to 5.6.2.
  • copy-webpack-plugin from 13.0.0 to 13.0.1.
  • cssnano from 7.0.6 to 7.1.2.
  • dotenv from 16.4.7 to 17.2.3.
  • dotenv-expand from 12.0.1 to 12.0.3.
  • grunt-sass from 4.0.0 to 4.0.1.
  • postcss from 8.5.3 to 8.5.6.
  • qunit from 2.23.1 to 2.24.2.
  • sass from 1.85.1 to 1.94.0.
  • terser-webpack-plugin from 5.3.12 to 5.3.14.
  • uuid from 11.1.0 to 13.0.0.
  • wait-on from 8.0.2 to 9.0.3.

A new variable, DOTENV_CONFIG_QUIET, has been added to the .env.example file to silence tips output by the dotenv dependency.

Additionally, npm audit fix has been run.

Props peterwilsoncc, desrosj.
See #63171.

@desrosj commented on PR #10501:


4 days ago
#15

The browserlist config in TT2 and TT5 are using older versions than the other themes. It would be good if they were consistent

I think I'd like to look at that separately. Historically, I believe that we have not changed the browser support policies for default themes to avoid possibly breaking child themes or custom CSS.

Hat tip to @peterwilsoncc, I just realized that TT2 and TT5 now have package.json files. I've gone and updated the dependencies for those themes as well.

#16 @desrosj
4 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 61206:

Build/Test Tools: Update dependencies for bundled themes.

This updates the devDependencies for each of the default themes with package.json files with a few exceptions:

  • eslint: This was updated to the latest 8.x version only since 9.x is not yet properly supported by @wordpress/eslint-plugin.
  • stylelint-related packages: these updates are resulting in formatting changes. These need to be examined more carefully as they’re likely undesired and require adjustments to the configuration file.

Props peterwilsoncc, desrosj.
Fixes #63171.

#17 @desrosj
4 days ago

I've created #64230 for the 7.0 release cycle.

Note: See TracTickets for help on using tickets.