Opened 17 months ago
Closed 13 months ago
#61608 closed task (blessed) (fixed)
Docblock improvements for WP 6.7
| Reported by: | | Owned by: | |
|---|---|---|---|
| Milestone: | 6.7 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | General | Keywords: | has-patch has-unit-tests |
| Focuses: | docs, coding-standards | Cc: |
Change History (31)
This ticket was mentioned in PR #5010 on WordPress/wordpress-develop by @NekoJonez.
16 months ago #1
- Keywords has-patch added
@SergeyBiryukov commented on PR #5010:
16 months ago #3
Thanks for the PR! Merged in r58842.
This ticket was mentioned in PR #2587 on WordPress/wordpress-develop by @krupalpanchal.
16 months ago #4
According to Inline Documentation Standards, just removed extra space from the comment.
- Inline Documentation Standards: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/
@SergeyBiryukov commented on PR #2587:
16 months ago #6
Thanks for the PR! Merged in r58865.
This ticket was mentioned in PR #7259 on WordPress/wordpress-develop by @rodrigosprimo.
15 months ago #9
- Keywords has-unit-tests added
The return value documentation for the get_*_meta() and get_metadata() functions incorrectly stated that an empty string is returned if a valid but non-existing object ID is passed. Actually, an empty string is returned if a valid but non-existing object ID is passed and $single is true. Otherwise, an empty array is returned.
This PR fixes the return value documentation for those functions.
It also includes some very basic tests documenting this behavior for get_metadata(). Happy to add similar tests for the other functions if needed.
The documentation that is modified by this PR was added in https://core.trac.wordpress.org/changeset/50641.
#11
@
15 months ago
Noting here that I created https://github.com/WordPress/wordpress-develop/pull/7259 to fix the return value documentation for get_*_meta() functions.
I found that the sentence in this doc flows weird... It's as if there is a verb missing.
Trac ticket:
https://core.trac.wordpress.org/ticket/61608
https://core.trac.wordpress.org/ticket/58833