Opened 9 years ago
Closed 9 years ago
#37492 closed defect (bug) (wontfix)
Unifying translation strings in wp_die()
| Reported by: | | Owned by: | |
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | I18N | Keywords: | has-patch |
| Focuses: | administration | Cc: |
Description
In ticket #34521 (Unifying permission error messages) we updated hundreds of translation strings inside wp_die(), fixing error messages you usually see after permission check if ( ! current_user_can( 'xxx' ) ).
In this ticket, we are going to fix 24 translation strings inside wp_die() that use <h1> and <p> tags.
I should say that we can either fix over 500 strings inside wp_die() and add HTML tags (<h1> & <p>) to all of them. Or, we can remove those unneeded HTML tags from 24 strings and unify translation strings in wp_die().
Attachments (2)
Change History (15)
This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.
9 years ago
This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.
9 years ago
#8
@
9 years ago
I updated the patch after changeset 38698. And I found few more wp_die() with HTML tags. Total 32 items updated.
Again, no text changes, the patch removes the 'Cheatin’ uh?' title and the HTML tags.
#9
@
9 years ago
None of the strings include HTML tags. Which I18N issue are you trying to fix? What am I missing here?
#10
@
9 years ago
@ocean90 I'm not fixing anything, I'm trying to unify translation strings inside wp_die(). The i18n component seems like the most suitable component for this ticket.
You are right, the strings have no HTML tags, but the wp_die() do have HTML tags.
I just want to have a standard way to show error messages. Either with H1 tags, in this case lets add them to all 500+ other die functions, or remove the H1 tags from the remaining 32 die functions.
no string changes, only HTML tags removal.