goauth2: Allow for empty redirect URLs.

goauth2: Allow for empty redirect URLs. The previous behavior was to use the value "oob" when no redirect URL was specified, which prevented clients from actually having an empty redirect URL. This is a breaking changing for any clients that are doing out-of-band code exchange, and were relying on this behavior. The fix for these clients is to manually specify a RedirectURL of "oob". Fixes 17

[adg, 2013-06-04 23:01:36]

https://codereview.appspot.com/9824044/diff/1/oauth/oauth.go File oauth/oauth.go (right): https://codereview.appspot.com/9824044/diff/1/oauth/oauth.go#newcode98 oauth/oauth.go:98: RedirectURL string // Defaults to out-of-band mode if empty. update (remove) this comment too

[willnorris, 2013-06-04 23:04:33]

https://codereview.appspot.com/9824044/diff/1/oauth/oauth.go File oauth/oauth.go (right): https://codereview.appspot.com/9824044/diff/1/oauth/oauth.go#newcode98 oauth/oauth.go:98: RedirectURL string // Defaults to out-of-band mode if empty. On 2013/06/04 23:01:36, adg wrote: > update (remove) this comment too Done.

[adg, 2013-06-04 23:10:20]

LGTM Thanks!

[adg, 2013-06-04 23:13:57]

*** Submitted as https://code.google.com/p/goauth2/source/detail?r=cf01a4ad4a2e *** goauth2: Allow for empty redirect URLs. The previous behavior was to use the value "oob" when no redirect URL was specified, which prevented clients from actually having an empty redirect URL. This is a breaking changing for any clients that are doing out-of-band code exchange, and were relying on this behavior. The fix for these clients is to manually specify a RedirectURL of "oob". Fixes 17 R=adg CC=golang-dev https://codereview.appspot.com/9824044 Committer: Andrew Gerrand <adg@golang.org>