sandbox event simulator

sandbox event simulator This is currently a prototype and I'm looking for feedback. Currently this is a (flexible) framework for manipulating backend state with various agents, a few are included by default and we can easily add others if we want. Its currently configured so that if you check it out, run it and do a drag drop import of improv data you'll see some changes every 3 seconds or so. In testing this I discovered a number of bugs and fixed them. Subordinate units import properly Fix sandbox annotation handling (for env) UnitCount Agent Unit Position Agent Annotation moves use transition. Force annotation set on layout placement of new nodes. removeUnits now updates deltaStream removeUnits now skips subordinates properly remove flicker around landcape badges in env view https://code.launchpad.net/~bcsaller/juju-gui/simulator-fo-realz/+merge/162301 (do not edit description out of merge proposal)

[bcsaller, 2013-05-03 07:24:11]

Please take a look.

[bcsaller, 2013-05-04 04:15:06]

Please take a look.

[gary.poster, 2013-05-04 12:53:29]

On 2013/05/04 04:15:06, bcsaller wrote: > Please take a look. Thanks for fixing subordinates and Landscape! cool. The flipping is disorienting, unlike all of the other changes. It is good to have for testing, but for demos it is the only one I would really want to turn off. In that vein, I'd be tempted to let the config file specify which simulation features to turn on, rather than (or in addition to, perhaps?) true and false. I've only skimmed the code, but test_simulator pretty clearly looks like it needs some loving before we actually land this, yeah? As a separate topic, I really think it would be nice to be able to turn this kind of functionality on and off dynamically over the web, and url namespaces or query strings seem like the natural fit. That would be for later. This will be a great testing and demo tool, thank you.

[bcsaller, 2013-05-04 17:17:47]

I still have to document the API, mostly what attrs mean to agents. Position flip agent was a joke but it did help me identify a couple issues with both annotation handling and new position assignments.

[bcsaller, 2013-05-05 09:06:28]

Please take a look.

[bcsaller, 2013-05-05 09:07:18]

This version has improved testing and docs

[gary.poster, 2013-05-05 11:29:12]

I will try to review later today. https://codereview.appspot.com/9153044/diff/9001/undocumented File undocumented (right): https://codereview.appspot.com/9153044/diff/9001/undocumented#newcode19 undocumented:19: app/store/env/simulator.js:234 "_updateAgents" Please make sure the total line count is same or fewer.

[bcsaller, 2013-05-05 22:30:50]

Please take a look.

[gary.poster, 2013-05-06 04:37:15]

On 2013/05/05 22:30:50, bcsaller wrote: > Please take a look. I'm getting a possibly intermittent qa problem. When I view a service with reported Landscape problems, I get this error: Uncaught TypeError: Cannot read property 'landscape-computers' of undefined (landscape.js line 124) I still want undocumented to be cleaned up. :-P I'm still not doing an in-depth review because of lack of time, sorry. :-/ addressing those two issues would be cool though. Thanks Gary

[bcsaller, 2013-05-07 00:58:08]

Please take a look.

[gary.poster, 2013-05-07 14:12:46]

Notes while doing QA: - When importing sample.json... - Invalid change data in _process_delta: Object {} - Service missing the landscape-computers annotation! - When importing large.json... - Same as above - Two times in crashed Chrome ("Aw, snap") - When importing openstack.json... - app reported successful import but no services appeared - console reported errors. Easily fixed--change the .json file to point to rabbitmq-server, not rabbitmq--but error should be reported. Will look more later. Sorry that this is catch as catch can.

[bcsaller, 2013-05-07 17:54:11]

Please take a look.

[bcsaller, 2013-05-07 17:54:25]

Thanks, _process_delta: added exception when delta is null. Generation of a null delta could still happen. Service missing the landscape-computers annotation! This isn't the same error as before. This is now a warning rather than an error. Its harmless. There is a real race between incoming nodes and landscape's ability to set annotations on the node. This happens real world and this warning shows that. Because this happens real world we might want to remove the warning? Two times in crashed Chrome ("Aw, snap") Not sure what I can do about this. I was able to crash things when dragging data to an older version of the gui that couldn't handle clipboard data but not in the general case. - When importing openstack.json... - app reported successful import but no services appeared - console reported errors. Easily fixed--change the .json file to point to rabbitmq-server, not rabbitmq--but error should be reported. Currently import uses a batch promise to import charms, when this fails the import aborts. Not part of simulator but I'll see about adding a notification for this case. (Later) This turned into allowing notifications to handle HTML formatted strings in the template and passing a better error up through the chain. Commented in the code.

[matthew.scott, 2013-05-09 22:16:26]

LGTM - thanks for all the work on this. I think this will really help the development story. The only questions I have are whether or not this should be on by default, and if so, whether or not 3s is too often.

[jeff.pihach, 2013-05-09 23:02:11]

LGTM - Thanks for putting this together it will really help us develop and test using something that feels like a real environment. I am not entirely sure that it should be included for everyone but that's something we can revisit later. https://codereview.appspot.com/9153044/diff/23001/app/app.js File app/app.js (right): https://codereview.appspot.com/9153044/diff/23001/app/app.js#newcode1130 app/app.js:1130: 'juju-fakebackend-simulator', I am not sure if this should be included for everyone https://codereview.appspot.com/9153044/diff/23001/app/models/models.js File app/models/models.js (right): https://codereview.appspot.com/9153044/diff/23001/app/models/models.js#newcod... app/models/models.js:141: annotations: {value: {}}, Could you add some documentation to this attribute please. https://codereview.appspot.com/9153044/diff/23001/app/store/env/fakebackend.js File app/store/env/fakebackend.js (right): https://codereview.appspot.com/9153044/diff/23001/app/store/env/fakebackend.j... app/store/env/fakebackend.js:1267: Y.batch.apply(self, charms) // resolve all the charms There might be some value in documenting what this is doing https://codereview.appspot.com/9153044/diff/23001/app/store/env/simulator.js File app/store/env/simulator.js (right): https://codereview.appspot.com/9153044/diff/23001/app/store/env/simulator.js#... app/store/env/simulator.js:396: // WHen our agents property changes When https://codereview.appspot.com/9153044/diff/23001/test/test_simulator.js File test/test_simulator.js (right): https://codereview.appspot.com/9153044/diff/23001/test/test_simulator.js#newc... test/test_simulator.js:86: agentShould('should be able to run decalred agents', function() { declared

[bcsaller, 2013-05-09 23:17:35]

Thanks for the reviews! https://codereview.appspot.com/9153044/diff/23001/app/app.js File app/app.js (right): https://codereview.appspot.com/9153044/diff/23001/app/app.js#newcode1130 app/app.js:1130: 'juju-fakebackend-simulator', On 2013/05/09 23:02:11, jeff.pihach wrote: > I am not sure if this should be included for everyone I don't mind having the code around but if you want a slack task for this its FBM https://codereview.appspot.com/9153044/diff/23001/app/models/models.js File app/models/models.js (right): https://codereview.appspot.com/9153044/diff/23001/app/models/models.js#newcod... app/models/models.js:141: annotations: {value: {}}, On 2013/05/09 23:02:11, jeff.pihach wrote: > Could you add some documentation to this attribute please. Done. https://codereview.appspot.com/9153044/diff/23001/app/store/env/fakebackend.js File app/store/env/fakebackend.js (right): https://codereview.appspot.com/9153044/diff/23001/app/store/env/fakebackend.j... app/store/env/fakebackend.js:1267: Y.batch.apply(self, charms) // resolve all the charms On 2013/05/09 23:02:11, jeff.pihach wrote: > There might be some value in documenting what this is doing Done. https://codereview.appspot.com/9153044/diff/23001/app/store/env/simulator.js File app/store/env/simulator.js (right): https://codereview.appspot.com/9153044/diff/23001/app/store/env/simulator.js#... app/store/env/simulator.js:396: // WHen our agents property changes On 2013/05/09 23:02:11, jeff.pihach wrote: > When Thanks https://codereview.appspot.com/9153044/diff/23001/test/test_simulator.js File test/test_simulator.js (right): https://codereview.appspot.com/9153044/diff/23001/test/test_simulator.js#newc... test/test_simulator.js:86: agentShould('should be able to run decalred agents', function() { On 2013/05/09 23:02:11, jeff.pihach wrote: > declared Done.

[bcsaller, 2013-05-09 23:22:02]

*** Submitted: sandbox event simulator This is currently a prototype and I'm looking for feedback. Currently this is a (flexible) framework for manipulating backend state with various agents, a few are included by default and we can easily add others if we want. Its currently configured so that if you check it out, run it and do a drag drop import of improv data you'll see some changes every 3 seconds or so. In testing this I discovered a number of bugs and fixed them. Subordinate units import properly Fix sandbox annotation handling (for env) UnitCount Agent Unit Position Agent Annotation moves use transition. Force annotation set on layout placement of new nodes. removeUnits now updates deltaStream removeUnits now skips subordinates properly remove flicker around landcape badges in env view R=gary.poster, matthew.scott, jeff.pihach CC= https://codereview.appspot.com/9153044