Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 7933043: code review 7933043: crypto/tls: use method values

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by bradfitz
Modified:
12 years, 3 months ago
Reviewers:
agl1, rsc
CC:
golang-dev, agl1, rsc
Visibility:
Public.

Description

crypto/tls: use method values Currently fails with a compiler error, though.

Patch Set 1 #

Patch Set 2 : diff -r 85b1cc5d35dd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 85b1cc5d35dd https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M src/pkg/crypto/tls/common.go View 1 1 chunk +18 lines, -1 line 0 comments Download
M src/pkg/crypto/tls/handshake_server.go View 1 1 chunk +1 line, -16 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 7 months ago (2013-03-20 22:18:52 UTC) #1
agl1
LGTM
12 years, 7 months ago (2013-03-20 22:28:29 UTC) #2
rsc
LGTM Will submit once I fix the compiler.
12 years, 7 months ago (2013-03-21 01:50:56 UTC) #3
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=c246dbf446db *** crypto/tls: use method values Currently fails with a compiler error, ...
12 years, 7 months ago (2013-03-21 03:53:42 UTC) #4
remyoudompheng
12 years, 3 months ago (2013-07-21 10:22:26 UTC) #5
R=close
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b