code review 75210044: runtime: avoid runtime·cgocall in functions called by ...

runtime: avoid runtime·cgocall in functions called by forkAndExecInChild Calling runtime·cgocall could trigger a GC in the child while gclock was held by the parent. Fixes issue 7511

[aram, 2014-03-13 06:57:34]

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

[dave_cheney.net, 2014-03-13 06:59:19]

This looks like the right fix, testing now.

[aram, 2014-03-13 06:59:41]

[+dvyukov, +rsc]

[bradfitz, 2014-03-13 06:59:48]

LGTM On Mar 12, 2014 11:57 PM, <aram@mgk.ro> wrote: > Reviewers: golang-codereviews, > > Message: > Hello golang-codereviews@googlegroups.com, > > I'd like you to review this change to > https://code.google.com/p/go > > > Description: > runtime: avoid runtime·cgocall in functions called by forkAndExecInChild > > Calling runtime·cgocall could trigger a GC in the child while > gclock was held by the parent. > > Fixes issue 7511 > > Please review this at https://codereview.appspot.com/75210044/ > > Affected files (+4, -4 lines): > M src/pkg/runtime/syscall_solaris.goc > > > Index: src/pkg/runtime/syscall_solaris.goc > =================================================================== > --- a/src/pkg/runtime/syscall_solaris.goc > +++ b/src/pkg/runtime/syscall_solaris.goc > @@ -170,7 +170,7 @@ > c.fn = (void*)libc·execve; > c.n = 3; > c.args = (void*)&path; > - runtime·cgocall(runtime·asmsysvicall6, &c); > + runtime·asmcgocall(runtime·asmsysvicall6, &c); > err = c.err; > } > > @@ -193,7 +193,7 @@ > c.fn = (void*)libc·fcntl; > c.n = 3; > c.args = (void*)&fd; > - runtime·cgocall(runtime·asmsysvicall6, &c); > + runtime·asmcgocall(runtime·asmsysvicall6, &c); > err = c.err; > val = c.r1; > } > @@ -227,7 +227,7 @@ > c.fn = (void*)libc·ioctl; > c.n = 3; > c.args = (void*)&fd; > - runtime·cgocall(runtime·asmsysvicall6, &c); > + runtime·asmcgocall(runtime·asmsysvicall6, &c); > err = c.err; > } > > @@ -338,7 +338,7 @@ > c.fn = (void*)libc·write; > c.n = 3; > c.args = (void*)fd; > - runtime·cgocall(runtime·asmsysvicall6, &c); > + runtime·asmcgocall(runtime·asmsysvicall6, &c); > err = c.err; > n = c.r1; > } > > > -- > You received this message because you are subscribed to the Google Groups > "golang-codereviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-codereviews+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > 

[dvyukov, 2014-03-13 07:03:36]

LGTM

[dave_cheney.net, 2014-03-13 07:07:18]

LGTM, passes on the solaris 11 builder. I will submit this shortly.

[dave_cheney.net, 2014-03-13 07:26:16]

*** Submitted as https://code.google.com/p/go/source/detail?r=d8c952ef0940 *** runtime: avoid runtime·cgocall in functions called by forkAndExecInChild Calling runtime·cgocall could trigger a GC in the child while gclock was held by the parent. Fixes issue 7511 LGTM=bradfitz, dvyukov, dave R=golang-codereviews, bradfitz, dvyukov, dave CC=golang-codereviews, rsc https://codereview.appspot.com/75210044 Committer: Dave Cheney <dave@cheney.net>