Use a CSS minifier that doesn't require Java

Use a CSS minifier that doesn't require Java Don't blink or you'll miss it. https://code.launchpad.net/~benji/juju-gui/use-uglify-4/+merge/145258 (do not edit description out of merge proposal)

[benji, 2013-01-28 21:50:42]

Please take a look.

[bac, 2013-01-28 21:58:00]

Land as is.

[matthew.scott, 2013-01-28 23:08:34]

I'm seeing the following error when running merge-files: { [Error: Command failed: /bin/sh: 1: undefined: not found] killed: false, code: 127, signal: null } Very unhelpful. Thanks node :) It's not showing up in trunk, and node debug bin/merge-files isn't breaking on it, so I'm not quite sure what's going on. If it's just me, I can try to find out what's going on, but I'd like some other eyes on this before I give it the thumbs up.

[bcsaller, 2013-01-28 23:13:40]

On 2013/01/28 23:08:34, matthew.scott wrote: > I'm seeing the following error when running merge-files: > > { [Error: Command failed: /bin/sh: 1: undefined: not found] killed: false, code: > 127, signal: null } > > Very unhelpful. Thanks node :) > > It's not showing up in trunk, and node debug bin/merge-files isn't breaking on > it, so I'm not quite sure what's going on. If it's just me, I can try to find > out what's going on, but I'd like some other eyes on this before I give it the > thumbs up. This didn't update package json, my guess is we need a newer version of minify and to add sqwish.

[benji, 2013-01-29 12:54:45]

On Mon, Jan 28, 2013 at 11:13 PM, <bcsaller@gmail.com> wrote: > On 2013/01/28 23:08:34, matthew.scott wrote: >> >> I'm seeing the following error when running merge-files: > > >> { [Error: Command failed: /bin/sh: 1: undefined: not found] killed: > > false, code: >> >> 127, signal: null } > > >> Very unhelpful. Thanks node :) > > >> It's not showing up in trunk, and node debug bin/merge-files isn't > > breaking on >> >> it, so I'm not quite sure what's going on. If it's just me, I can try > > to find >> >> out what's going on, but I'd like some other eyes on this before I > > give it the >> >> thumbs up. > > > This didn't update package json, my guess is we need a newer version of > minify and to add sqwish. Indeed! I am not sure how the submitted branch worked at all. The package update didn't get moved from my prototype branch. I have fixed this oversight. -- Benji York 

[benji, 2013-01-29 13:39:03]

*** Submitted: Use a CSS minifier that doesn't require Java Don't blink or you'll miss it. R=bac, matthew.scott, bcsaller CC= https://codereview.appspot.com/7228054

[bcsaller, 2013-01-29 14:06:53]

On 2013/01/29 13:39:03, benji wrote: > *** Submitted: > > Use a CSS minifier that doesn't require Java > > Don't blink or you'll miss it. > > R=bac, matthew.scott, bcsaller > CC= > https://codereview.appspot.com/7228054 LGTM