Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(372)

Issue 6662045: Console log debugability

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by bcsaller
Modified:
13 years ago
Reviewers:
mp+129508
Visibility:
Public.

Description

Console log debugability Simpler console log manager that when enabled will still report proper lineno's and call-stacks. This doesn't currently wrap the full console api, but we could easily add missing methods to consoleNoop if we wanted. The working set there now covers the common cases. https://code.launchpad.net/~bcsaller/juju-ui/console/+merge/129508 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Console log debugability #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -123 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 1 chunk +2 lines, -2 lines 0 comments Download
M app/views/utils.js View 1 1 chunk +32 lines, -44 lines 0 comments Download
M test/test_console.js View 1 chunk +38 lines, -77 lines 0 comments Download

Messages

Total messages: 3
bcsaller
Please take a look.
13 years ago (2012-10-12 20:15:03 UTC) #1
hazmat
thanks looks good. https://codereview.appspot.com/6662045/diff/1/app/views/utils.js File app/views/utils.js (right): https://codereview.appspot.com/6662045/diff/1/app/views/utils.js#newcode37 app/views/utils.js:37: log: noop time/timeEnd pretty please ;-) ...
13 years ago (2012-10-12 21:05:04 UTC) #2
bcsaller
13 years ago (2012-10-12 21:10:24 UTC) #3
*** Submitted: Console log debugability Simpler console log manager that when enabled will still report proper lineno's and call-stacks. This doesn't currently wrap the full console api, but we could easily add missing methods to consoleNoop if we wanted. The working set there now covers the common cases. R=hazmat CC= https://codereview.appspot.com/6662045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b