Issue 60980043: code review 60980043: container/list: mark must be an element of the list

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 60980043: code review 60980043: container/list: mark must be an element of the list

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by zimmski

Modified:
11 years, 8 months ago

Reviewers:
gri

CC:
golang-codereviews, gobot, gri

Visibility:
Public.

Description

container/list: mark must be an element of the list The methods MoveAfter and MoveBefore of the container/list package did silently corrupt the interal structure of the list if a mark element is used which is not an element of the list.

Patch Set 1 #

Patch Set 2 : diff -r e2f19c96b7e2 https://code.google.com/p/go #

Patch Set 3 : diff -r e2f19c96b7e2 https://code.google.com/p/go #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -4 lines)			Patch
	M	src/pkg/container/list/list.go	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
	M	src/pkg/container/list/list_test.go	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

*** Submitted as https://code.google.com/p/go/source/detail?r=2adfffbb15de *** container/list: mark must be an element of the list The methods MoveAfter and MoveBefore of the container/list package did silently corrupt the interal structure of the list if a mark element is used which is not an element of the list. LGTM=gri R=golang-codereviews, gobot, gri CC=golang-codereviews https://codereview.appspot.com/60980043 Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages