code review 40370051: database/sql: Fix inaccurate comment

database/sql: Fix inaccurate comment

[johto, 2013-12-12 21:55:37]

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

[bradfitz, 2013-12-17 22:53:08]

LGTM On Thu, Dec 12, 2013 at 1:55 PM, <marko@joh.to> wrote: > Reviewers: golang-dev1, > > Message: > Hello golang-dev@googlegroups.com, > > I'd like you to review this change to > https://code.google.com/p/go > > > Description: > database/sql: Fix inaccurate comment > > Please review this at https://codereview.appspot.com/40370051/ > > Affected files (+2, -2 lines): > M src/pkg/database/sql/sql.go > > > Index: src/pkg/database/sql/sql.go > =================================================================== > --- a/src/pkg/database/sql/sql.go > +++ b/src/pkg/database/sql/sql.go > @@ -774,8 +774,8 @@ > // Satisfy a connRequest or put the driverConn in the idle pool and > return true > // or return false. > // putConnDBLocked will satisfy a connRequest if there is one, or it will > -// return the *driverConn to the freeConn list if err != nil and the idle > -// connection limit would not be reached. > +// return the *driverConn to the freeConn list if err == nil and the idle > +// connection limit will not be exceeded. > // If err != nil, the value of dc is ignored. > // If err == nil, then dc must not equal nil. > // If a connRequest was fullfilled or the *driverConn was placed in the > > > -- > > ---You received this message because you are subscribed to the Google > Groups "golang-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > 

[bradfitz, 2013-12-17 22:53:33]

*** Submitted as https://code.google.com/p/go/source/detail?r=4ecb249c58ee *** database/sql: Fix inaccurate comment R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/40370051 Committer: Brad Fitzpatrick <bradfitz@golang.org>