Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(673)

Issue 201054: Change default label's date forward to avoid slashes

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by Greg Robbins
Modified:
15 years, 8 months ago
Reviewers:
thomasvl
Base URL:
http://google-email-uploader-mac.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Use a custom date format in the default label to avoid the slashes present in the standard short format, as slashes in labels can turn into a folder hierarchy for Gmail's IMAP clients. Also, adding release notes to the project file.

Patch Set 1 #

Patch Set 2 : tweaked comment #

Patch Set 3 : updates release notes #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M Source/EmUpWindowController.m View 1 2 1 chunk +3 lines, -1 line 1 comment Download
M Source/EmailUploader.xcodeproj/project.pbxproj View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
M Source/ReleaseNotes.txt View 1 2 1 chunk +14 lines, -0 lines 1 comment Download

Messages

Total messages: 3
Greg Robbins
15 years, 8 months ago (2010-02-17 20:20:33 UTC) #1
thomasvl
http://codereview.appspot.com/201054/diff/2001/2003 File Source/EmUpWindowController.m (right): http://codereview.appspot.com/201054/diff/2001/2003#newcode142 Source/EmUpWindowController.m:142: NSString *dateStr = [dateFormatter stringFromDate:[NSDate date]]; i almost hate ...
15 years, 8 months ago (2010-02-17 20:27:38 UTC) #2
thomasvl
15 years, 8 months ago (2010-02-17 20:34:45 UTC) #3
lgtm in any case.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b