Change default label's date forward to avoid slashes

Source/EmUpWindowController.m

 /* Copyright (c) 2009 Google Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 117 matching lines @@
 
 - (void)awakeFromNib {
 [tabView_ selectTabViewItemWithIdentifier:kTabViewItemSelection];
 
 // Make a suggested custom e-mail label of "Uploaded 1/2/34" with today's
 // date, which is useful if the user wants to be able to select & delete these
 // uploads
 NSDateFormatter *dateFormatter = [[[NSDateFormatter alloc] init] autorelease];
 [dateFormatter setFormatterBehavior:NSDateFormatterBehavior10_4];
 
- [dateFormatter setDateStyle:NSDateFormatterShortStyle];
+ // we'll use a custom date format to avoid slashes in the tag, as slashes may
+ // be interpreted by IMAP clients as a folder hierarchy
 [dateFormatter setTimeStyle:NSDateFormatterNoStyle];
+[dateFormatter setDateFormat:@"dd-MMM-yyyy"];
 NSString *dateStr = [dateFormatter stringFromDate:[NSDate date]];

[thomasvl, 2010/02/17 20:27:38]

i almost hate to suggest this, but what about sticking with Short, and after you get dateStr replacing '/' with '-'? That way the user's localization prefs still apply for the order of the segments, but you solve the problem if the languages uses '/'? 

 
 NSString *template = NSLocalizedString(@"UploadDateTemplate", nil); // "Upload ed %@"
 NSString *suggestedLabel = [NSString stringWithFormat:template, dateStr];
 [additionalLabelField_ setStringValue:suggestedLabel];
 
 // normally we reset just before a new upload, but calling this from
 // awakeFromNib now will clear the skipped files pop-up menu of its nib-loaded
 // item
 [self resetUploading];
 
@@ skipping 1482 matching lines @@
 - (void)setLastUploadDate:(NSDate *)date {
 [lastUploadDate_ release];
 lastUploadDate_ = [date retain];
 }
 
 - (void)setSimulateUploads:(BOOL)flag {
 shouldSimulateUploads_ = flag;
 }
 
 @end