code review 192030043: compiler: Use function receiver name in mangled named t...

compiler: Use function receiver name in mangled named type descriptor. If named types with similar names are defined inside of methods with similar names, it was possible that the mangled type names would be the same, leading to multiple definitions of type descriptor and garbage collection info variables. This can only occur with similarly named methods across different receivers, so we use the receiver name to distinguish. Fixes issue 33.

[cmang, 2014-12-19 22:09:07]

Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/gofrontend

[iant, 2014-12-23 23:28:18]

https://codereview.appspot.com/192030043/diff/40001/go/types.cc File go/types.cc (right): https://codereview.appspot.com/192030043/diff/40001/go/types.cc#newcode1304 go/types.cc:1304: Gogo::unpack_hidden_name(rcvr->type()->named_type()->name()); I don't think this will work for a pointer receiver. I think there needs to be a deref() in there.

[cmang, 2014-12-29 22:07:06]

https://codereview.appspot.com/192030043/diff/40001/go/types.cc File go/types.cc (right): https://codereview.appspot.com/192030043/diff/40001/go/types.cc#newcode1304 go/types.cc:1304: Gogo::unpack_hidden_name(rcvr->type()->named_type()->name()); On 2014/12/23 23:28:17, iant wrote: > I don't think this will work for a pointer receiver. I think there needs to be > a deref() in there. Done.

[iant, 2015-01-06 02:24:18]

LGTM

[iant, 2015-01-06 02:26:06]

*** Submitted as https://code.google.com/p/gofrontend/source/detail?r=e69aeba5ad07 *** compiler: Use function receiver name in mangled named type descriptor. If named types with similar names are defined inside of methods with similar names, it was possible that the mangled type names would be the same, leading to multiple definitions of type descriptor and garbage collection info variables. This can only occur with similarly named methods across different receivers, so we use the receiver name to distinguish. Fixes issue 33. LGTM=iant R=iant CC=gofrontend-dev https://codereview.appspot.com/192030043 Committer: Ian Lance Taylor <iant@golang.org>