Issue 188910043: code review 188910043: runtime: Don't crash when deleting zero-sized key.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 188910043: code review 188910043: runtime: Don't crash when deleting zero-sized key.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by cmang

Modified:
10 years, 10 months ago

Reviewers:
iant

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

runtime: Don't crash when deleting zero-sized key. Fixes gcc.gnu.org/PR61258.

Patch Set 1 #

Patch Set 2 : diff -r 1bed87327b5c https://code.google.com/p/gofrontend #

Patch Set 3 : diff -r 1bed87327b5c https://code.google.com/p/gofrontend #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	libgo/runtime/go-map-delete.c	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

*** Submitted as https://code.google.com/p/gofrontend/source/detail?r=08fdb81ed1ec *** runtime: Don't crash when deleting zero-sized key. Fixes gcc.gnu.org/PR61258. LGTM=iant R=iant CC=gofrontend-dev https://codereview.appspot.com/188910043 Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages