Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(183)

Issue 188910043: code review 188910043: runtime: Don't crash when deleting zero-sized key.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by cmang
Modified:
10 years, 10 months ago
Reviewers:
iant
CC:
iant, gofrontend-dev_googlegroups.com
Visibility:
Public.

Description

runtime: Don't crash when deleting zero-sized key. Fixes gcc.gnu.org/PR61258.

Patch Set 1 #

Patch Set 2 : diff -r 1bed87327b5c https://code.google.com/p/gofrontend #

Patch Set 3 : diff -r 1bed87327b5c https://code.google.com/p/gofrontend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M libgo/runtime/go-map-delete.c View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3
cmang
Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/gofrontend
10 years, 10 months ago (2014-12-10 21:51:52 UTC) #1
iant
LGTM
10 years, 10 months ago (2014-12-13 01:57:04 UTC) #2
iant
10 years, 10 months ago (2014-12-13 01:57:56 UTC) #3
*** Submitted as https://code.google.com/p/gofrontend/source/detail?r=08fdb81ed1ec *** runtime: Don't crash when deleting zero-sized key. Fixes gcc.gnu.org/PR61258. LGTM=iant R=iant CC=gofrontend-dev https://codereview.appspot.com/188910043 Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b