Issue 185440043: code review 185440043: compiler: Copied variadic calls should copy lowering st...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 185440043: code review 185440043: compiler: Copied variadic calls should copy lowering st...

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by cmang

Modified:
10 years, 10 months ago

Reviewers:
iant

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

compiler: Copied variadic calls should copy lowering state of arguments. Fixes gcc.gnu.org/PR61255.

Patch Set 1 #

Patch Set 2 : diff -r 67dd2c649e07 https://code.google.com/p/gofrontend #

Patch Set 3 : diff -r 67dd2c649e07 https://code.google.com/p/gofrontend #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -15 lines)			Patch
	M	go/expressions.h	View		2 chunks	+6 lines, -8 lines	0 comments	Download
	M	go/expressions.cc	View		3 chunks	+30 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

*** Submitted as https://code.google.com/p/gofrontend/source/detail?r=670705a1c9cc *** compiler: Copied variadic calls should copy lowering state of arguments. Fixes gcc.gnu.org/PR61255. LGTM=iant R=iant CC=gofrontend-dev https://codereview.appspot.com/185440043 Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages