Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(700)

Issue 185440043: code review 185440043: compiler: Copied variadic calls should copy lowering st...

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by cmang
Modified:
10 years, 10 months ago
Reviewers:
iant
CC:
iant, gofrontend-dev_googlegroups.com
Visibility:
Public.

Description

compiler: Copied variadic calls should copy lowering state of arguments. Fixes gcc.gnu.org/PR61255.

Patch Set 1 #

Patch Set 2 : diff -r 67dd2c649e07 https://code.google.com/p/gofrontend #

Patch Set 3 : diff -r 67dd2c649e07 https://code.google.com/p/gofrontend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -15 lines) Patch
M go/expressions.h View 2 chunks +6 lines, -8 lines 0 comments Download
M go/expressions.cc View 3 chunks +30 lines, -7 lines 0 comments Download

Messages

Total messages: 3
cmang
Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/gofrontend
10 years, 10 months ago (2014-12-15 19:45:29 UTC) #1
iant
LGTM
10 years, 10 months ago (2014-12-15 20:15:19 UTC) #2
iant
10 years, 10 months ago (2014-12-15 20:17:12 UTC) #3
*** Submitted as https://code.google.com/p/gofrontend/source/detail?r=670705a1c9cc *** compiler: Copied variadic calls should copy lowering state of arguments. Fixes gcc.gnu.org/PR61255. LGTM=iant R=iant CC=gofrontend-dev https://codereview.appspot.com/185440043 Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b