Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(134)

Issue 183350043: code review 183350043: compiler: Support RecvStmt = ExpressionList "=" RecvExpr.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by cmang
Modified:
10 years, 11 months ago
Reviewers:
iant
CC:
iant, gofrontend-dev_googlegroups.com
Visibility:
Public.

Description

compiler: Support RecvStmt = ExpressionList "=" RecvExpr. Fixes gcc.gnu.org/PR61253.

Patch Set 1 #

Patch Set 2 : diff -r 1bed87327b5c https://code.google.com/p/gofrontend #

Patch Set 3 : diff -r 1bed87327b5c https://code.google.com/p/gofrontend #

Total comments: 2

Patch Set 4 : diff -r fbb82148b328 https://code.google.com/p/gofrontend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M go/parse.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5
cmang
Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/gofrontend
10 years, 11 months ago (2014-12-12 21:28:15 UTC) #1
iant
https://codereview.appspot.com/183350043/diff/30002/go/parse.cc File go/parse.cc (right): https://codereview.appspot.com/183350043/diff/30002/go/parse.cc#newcode5034 go/parse.cc:5034: if (this->peek_token()->is_op(OPERATOR_COMMA)) I think this will wind up accepting ...
10 years, 11 months ago (2014-12-14 01:02:11 UTC) #2
cmang
https://codereview.appspot.com/183350043/diff/30002/go/parse.cc File go/parse.cc (right): https://codereview.appspot.com/183350043/diff/30002/go/parse.cc#newcode5034 go/parse.cc:5034: if (this->peek_token()->is_op(OPERATOR_COMMA)) On 2014/12/14 01:02:11, iant wrote: > I ...
10 years, 11 months ago (2014-12-15 15:52:15 UTC) #3
iant
LGTM
10 years, 11 months ago (2014-12-15 17:10:36 UTC) #4
iant
10 years, 11 months ago (2014-12-15 17:11:37 UTC) #5
*** Submitted as https://code.google.com/p/gofrontend/source/detail?r=86515da29da6 *** compiler: Support RecvStmt = ExpressionList "=" RecvExpr. Fixes gcc.gnu.org/PR61253. LGTM=iant R=iant CC=gofrontend-dev https://codereview.appspot.com/183350043 Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b