code review 176170043: cmd/go: fix running pprof on windows.

cmd/go: fix running pprof on windows. Fixes issue 9149.

[minux, 2014-11-21 23:03:33]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

[minux, 2014-11-21 23:04:03]

I think this should go into 1.4.

[dave_cheney.net, 2014-11-21 23:05:39]

I agree, if there is an rc2, it would be great to get some feedback from windows users. On Sat, Nov 22, 2014 at 10:04 AM, <minux@golang.org> wrote: > I think this should go into 1.4. > > https://codereview.appspot.com/176170043/ > > > -- > You received this message because you are subscribed to the Google Groups > "golang-codereviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-codereviews+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. 

[brainman, 2014-11-22 11:47:59]

On 2014/11/21 23:04:03, minux wrote: > I think this should go into 1.4. I agree. LGTM, but I don't have computer to test it. I will test it Monday. Thank you. Alex

[rsc, 2014-11-22 18:37:30]

LGTM 

[rsc, 2014-11-22 18:37:57]

*** Submitted as https://code.google.com/p/go/source/detail?r=61bbf19823d5 *** cmd/go: fix running pprof on windows. Fixes issue 9149. LGTM=alex.brainman, rsc R=rsc, dave, alex.brainman CC=golang-codereviews https://codereview.appspot.com/176170043 Committer: Russ Cox <rsc@golang.org>

[gobot, 2014-11-22 18:43:28]

This CL appears to have broken the netbsd-386-minux builder. See http://build.golang.org/log/fef3b2bb43e3101f8e8748e0d5183b1407f928b9

[brainman, 2014-11-24 01:10:31]

On 2014/11/22 11:47:59, brainman wrote: > > ... I will test it Monday. All works as expected. Alex

[minux, 2014-11-24 01:23:25]

On Sun, Nov 23, 2014 at 8:10 PM, <alex.brainman@gmail.com> wrote: > On 2014/11/22 11:47:59, brainman wrote: > > ... I will test it Monday. >> > > All works as expected. > Great! Thanks for confirmation. We probably don't need a RC2.