code review 170770043: cmd/go: fix minor typo

cmd/go: fix minor typo

[natefinch, 2014-10-30 14:28:43]

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

[bradfitz, 2014-10-30 14:48:08]

LGTM On Thu, Oct 30, 2014 at 11:28 AM, <nate.finch@gmail.com> wrote: > Reviewers: golang-codereviews, > > Message: > Hello golang-codereviews@googlegroups.com, > > I'd like you to review this change to > https://code.google.com/p/go > > > Description: > cmd/go: fix minor typo > > Please review this at https://codereview.appspot.com/170770043/ > > Affected files (+1, -1 lines): > M src/cmd/go/doc.go > > > Index: src/cmd/go/doc.go > =================================================================== > --- a/src/cmd/go/doc.go > +++ b/src/cmd/go/doc.go > @@ -247,7 +247,7 @@ > passed to the generator as individual arguments when it is run. > > Quoted strings use Go syntax and are evaluated before execution; a > -quoted string appears a single argument to the generator. > +quoted string appears as a single argument to the generator. > > Go generate sets several variables when it runs the generator: > > > > -- > You received this message because you are subscribed to the Google Groups > "golang-codereviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-codereviews+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > 

[bradfitz, 2014-10-30 14:49:41]

You don't appear to have submitted a CLA. On Thu, Oct 30, 2014 at 11:28 AM, <nate.finch@gmail.com> wrote: > Reviewers: golang-codereviews, > > Message: > Hello golang-codereviews@googlegroups.com, > > I'd like you to review this change to > https://code.google.com/p/go > > > Description: > cmd/go: fix minor typo > > Please review this at https://codereview.appspot.com/170770043/ > > Affected files (+1, -1 lines): > M src/cmd/go/doc.go > > > Index: src/cmd/go/doc.go > =================================================================== > --- a/src/cmd/go/doc.go > +++ b/src/cmd/go/doc.go > @@ -247,7 +247,7 @@ > passed to the generator as individual arguments when it is run. > > Quoted strings use Go syntax and are evaluated before execution; a > -quoted string appears a single argument to the generator. > +quoted string appears as a single argument to the generator. > > Go generate sets several variables when it runs the generator: > > > > -- > You received this message because you are subscribed to the Google Groups > "golang-codereviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-codereviews+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > 

[natefinch, 2014-10-30 17:41:49]

Oops, huh, I thought I'd done that a long time ago. Done now, anyway. On Thursday, October 30, 2014 10:49:41 AM UTC-4, Brad Fitzpatrick wrote: > > You don't appear to have submitted a CLA. > > > On Thu, Oct 30, 2014 at 11:28 AM, <nate....@gmail.com <javascript:>> > wrote: > >> Reviewers: golang-codereviews, >> >> Message: >> Hello golang-co...@googlegroups.com <javascript:>, >> >> I'd like you to review this change to >> https://code.google.com/p/go >> >> >> Description: >> cmd/go: fix minor typo >> >> Please review this at https://codereview.appspot.com/170770043/ >> >> Affected files (+1, -1 lines): >> M src/cmd/go/doc.go >> >> >> Index: src/cmd/go/doc.go >> =================================================================== >> --- a/src/cmd/go/doc.go >> +++ b/src/cmd/go/doc.go >> @@ -247,7 +247,7 @@ >> passed to the generator as individual arguments when it is run. >> >> Quoted strings use Go syntax and are evaluated before execution; a >> -quoted string appears a single argument to the generator. >> +quoted string appears as a single argument to the generator. >> >> Go generate sets several variables when it runs the generator: >> >> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "golang-codereviews" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to golang-codereviews+unsubscribe@googlegroups.com <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > >

[bradfitz, 2014-10-30 20:20:46]

*** Submitted as https://code.google.com/p/go/source/detail?r=bb82d18ac07a *** cmd/go: fix minor typo LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/170770043 Committer: Brad Fitzpatrick <bradfitz@golang.org>

[shurcooL, 2014-12-02 19:57:49]

Hehe, this is a good example of how comments like // DO NOT EDIT THIS FILE. GENERATED BY mkdoc.sh. are not the best way to communicate which files are generated (I don't know of a better way yet, but I'll be thinking about it). On 2014/10/30 20:20:46, bradfitz wrote: > *** Submitted as https://code.google.com/p/go/source/detail?r=bb82d18ac07a *** > > cmd/go: fix minor typo > > LGTM=bradfitz > R=golang-codereviews, bradfitz > CC=golang-codereviews > https://codereview.appspot.com/170770043 > > Committer: Brad Fitzpatrick <mailto:bradfitz@golang.org>

[natefinch, 2014-12-03 21:26:25]

On 2014/12/02 19:57:49, shurcooL wrote: > Hehe, this is a good example of how comments like > > // DO NOT EDIT THIS FILE. GENERATED BY mkdoc.sh. > > are not the best way to communicate which files are generated (I don't know of a > better way yet, but I'll be thinking about it). ummm... oops :) Seems like there should be a tool to check for this on submission (i.e., rerun the mkdoc.sh and ensure the output is the same as what is getting checked in).