Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(960)

Issue 157830044: code review 157830044: compiler: Don't record interface types with blank type ...

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by cmang
Modified:
11 years ago
Reviewers:
iant
CC:
iant, gofrontend-dev_googlegroups.com, gri
Visibility:
Public.

Description

compiler: Don't record interface types with blank type names. Fixes issue 8079.

Patch Set 1 #

Patch Set 2 : diff -r 9edf9d5cf2be https://code.google.com/p/gofrontend #

Patch Set 3 : diff -r 9edf9d5cf2be https://code.google.com/p/gofrontend #

Patch Set 4 : diff -r 72bb6aea3991 https://code.google.com/p/gofrontend #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M go/parse.h View 1 chunk +1 line, -1 line 0 comments Download
M go/parse.cc View 4 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 7
cmang
Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com, gri@golang.org), I'd like you to review this change to https://code.google.com/p/gofrontend
11 years ago (2014-10-10 20:05:41 UTC) #1
cmang
On 2014/10/10 20:05:41, cmang wrote: > Hello mailto:iant@golang.org (cc: mailto:gofrontend-dev@googlegroups.com, mailto:gri@golang.org), > > I'd like ...
11 years ago (2014-10-10 20:08:22 UTC) #2
cmang
On 2014/10/10 20:08:22, cmang wrote: > On 2014/10/10 20:05:41, cmang wrote: > > Hello mailto:iant@golang.org ...
11 years ago (2014-10-13 19:34:40 UTC) #3
iant
This patch now conflicts with trunk. Please "hg sync" and then "hg upload 157830044". Thanks.
11 years ago (2014-10-16 18:35:26 UTC) #4
cmang
On 2014/10/16 18:35:26, iant wrote: > This patch now conflicts with trunk. Please "hg sync" ...
11 years ago (2014-10-16 18:42:22 UTC) #5
iant
LGTM
11 years ago (2014-10-16 19:27:49 UTC) #6
iant
11 years ago (2014-10-16 19:28:18 UTC) #7
*** Submitted as https://code.google.com/p/gofrontend/source/detail?r=c401743ee460 *** compiler: Don't record interface types with blank type names. Fixes issue 8079. LGTM=iant R=iant CC=gofrontend-dev, gri https://codereview.appspot.com/157830044 Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b