Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(180)

Issue 152840043: code review 152840043: refect: fix direct call of variadic method value

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by mwhudson
Modified:
11 years ago
Reviewers:
iant
CC:
gofrontend-dev_googlegroups.com, iant
Visibility:
Public.

Description

refect: fix direct call of variadic method value As reported in bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61877 gcc mainline has regressed in this. This CL adds the tests proposed for the main Go repository: https://codereview.appspot.com/151280043/ https://codereview.appspot.com/152060043/ restores the code from the amd64/386 path that makes this work and was lost when the Go 1.3 stdlib was merged and changes the FFI path to call into the same helper code as the amd64/386 path. I've only tested this on amd64 but I did test a version that was patched to unconditionally take the FFI path.

Patch Set 1 #

Patch Set 2 : diff -r ae56e39c190fa444898e76f6268eb29c9a395357 https://code.google.com/p/gofrontend/ #

Patch Set 3 : diff -r ae56e39c190fa444898e76f6268eb29c9a395357 https://code.google.com/p/gofrontend/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -39 lines) Patch
M libgo/go/reflect/all_test.go View 1 5 chunks +71 lines, -6 lines 0 comments Download
M libgo/go/reflect/makefunc.go View 1 3 chunks +26 lines, -33 lines 0 comments Download

Messages

Total messages: 3
mwhudson
Hello gofrontend-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/gofrontend/
11 years ago (2014-10-03 02:48:21 UTC) #1
iant
LGTM Thanks.
11 years ago (2014-10-03 15:48:57 UTC) #2
iant
11 years ago (2014-10-03 15:51:13 UTC) #3
*** Submitted as https://code.google.com/p/gofrontend/source/detail?r=8fbb502cda79 *** refect: fix direct call of variadic method value As reported in bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61877 gcc mainline has regressed in this. This CL adds the tests proposed for the main Go repository: https://codereview.appspot.com/151280043/ https://codereview.appspot.com/152060043/ restores the code from the amd64/386 path that makes this work and was lost when the Go 1.3 stdlib was merged and changes the FFI path to call into the same helper code as the amd64/386 path. I've only tested this on amd64 but I did test a version that was patched to unconditionally take the FFI path. LGTM=iant R=gofrontend-dev, iant CC=gofrontend-dev https://codereview.appspot.com/152840043 Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b