code review 12180043: go.tools: add dashboard

go.tools: add dashboard Moving misc/dashboard to its new home. It will be deleted (except for misc/dashboard/codereview) from its current home if this is approved.

[cmang, 2013-07-31 16:51:14]

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

[bradfitz, 2013-07-31 17:57:42]

R=adg Currently we have commands under cmd and packages under the root. This is neither a command-line tool, nor a package. Not sure where it should go. On Wed, Jul 31, 2013 at 9:51 AM, <cmang@golang.org> wrote: > Reviewers: golang-dev1, > > Message: > Hello golang-dev@googlegroups.com, > > I'd like you to review this change to > https://code.google.com/p/go/ > > > Description: > go.tools: add dashboard > Moving misc/dashboard to its new home. It will be deleted > (except for misc/dashboard/codereview) from its current home > if this is approved. > > Please review this at https://codereview.appspot.**com/12180043/<https://codereview.appspot.com/121... > > Affected files: > A dashboard/README > A dashboard/app/app.yaml > A dashboard/app/build/build.go > A dashboard/app/build/handler.go > A dashboard/app/build/init.go > A dashboard/app/build/key.go > A dashboard/app/build/notify.go > A dashboard/app/build/notify.txt > A dashboard/app/build/test.go > A dashboard/app/build/ui.go > A dashboard/app/build/ui.html > A dashboard/app/cache/cache.go > A dashboard/app/static/status_**alert.gif > A dashboard/app/static/status_**good.gif > A dashboard/builder/Makefile > A dashboard/builder/doc.go > A dashboard/builder/exec.go > A dashboard/builder/http.go > A dashboard/builder/main.go > A dashboard/builder/vcs.go > > > -- > > ---You received this message because you are subscribed to the Google > Groups "golang-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou... > . > For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o... > . > > > 

[cmang2, 2013-07-31 21:33:11]

Maybe we can further split this up, so the builder goes into go.tools/cmd/go similarly to godoc and then the appengine application logic goes into its own repo similar to talks/blogs/etc? This might make sense since the appengine code for the dashboard and the builder itself aren't really related. People should be able to just attempt building Go on their machines and not really think about the dashboard unless they are given a builder's key. On Wed, Jul 31, 2013 at 10:57 AM, Brad Fitzpatrick <bradfitz@golang.org>wrote: > R=adg > > Currently we have commands under cmd and packages under the root. > > This is neither a command-line tool, nor a package. Not sure where it > should go. > > > > On Wed, Jul 31, 2013 at 9:51 AM, <cmang@golang.org> wrote: > >> Reviewers: golang-dev1, >> >> Message: >> Hello golang-dev@googlegroups.com, >> >> I'd like you to review this change to >> https://code.google.com/p/go/ >> >> >> Description: >> go.tools: add dashboard >> Moving misc/dashboard to its new home. It will be deleted >> (except for misc/dashboard/codereview) from its current home >> if this is approved. >> >> Please review this at https://codereview.appspot.**com/12180043/<https://codereview.appspot.com/121... >> >> Affected files: >> A dashboard/README >> A dashboard/app/app.yaml >> A dashboard/app/build/build.go >> A dashboard/app/build/handler.go >> A dashboard/app/build/init.go >> A dashboard/app/build/key.go >> A dashboard/app/build/notify.go >> A dashboard/app/build/notify.txt >> A dashboard/app/build/test.go >> A dashboard/app/build/ui.go >> A dashboard/app/build/ui.html >> A dashboard/app/cache/cache.go >> A dashboard/app/static/status_**alert.gif >> A dashboard/app/static/status_**good.gif >> A dashboard/builder/Makefile >> A dashboard/builder/doc.go >> A dashboard/builder/exec.go >> A dashboard/builder/http.go >> A dashboard/builder/main.go >> A dashboard/builder/vcs.go >> >> >> >> -- >> >> ---You received this message because you are subscribed to the Google >> Groups "golang-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou... >> . >> For more options, visit https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o... >> . >> >> >> > 

[adg, 2013-07-31 23:46:27]

I think it's fine to put this here. https://codereview.appspot.com/12180043/diff/6001/dashboard/app/build/build.go File dashboard/app/build/build.go (right): https://codereview.appspot.com/12180043/diff/6001/dashboard/app/build/build.g... dashboard/app/build/build.go:5: package build please add a build rule above this line (but with a blank between it and the package statement) // +build appengine to each of go files inside the app directory. this will prevent the files from being built by a non-appengine tool chain

[cmang, 2013-07-31 23:56:07]

https://codereview.appspot.com/12180043/diff/6001/dashboard/app/build/build.go File dashboard/app/build/build.go (right): https://codereview.appspot.com/12180043/diff/6001/dashboard/app/build/build.g... dashboard/app/build/build.go:5: package build On 2013/07/31 23:46:28, adg wrote: > please add a build rule above this line (but with a blank between it and the > package statement) > > // +build appengine > > to each of go files inside the app directory. this will prevent the files from > being built by a non-appengine tool chain Done.

[adg, 2013-08-01 00:09:54]

LGTM

[adg, 2013-08-01 03:24:01]

*** Submitted as https://code.google.com/p/go/source/detail?r=f2a3741e102e&repo=tools *** go.tools: add dashboard Moving misc/dashboard to its new home. It will be deleted (except for misc/dashboard/codereview) from its current home if this is approved. R=golang-dev, bradfitz, cmang, adg CC=golang-dev https://codereview.appspot.com/12180043 Committer: Andrew Gerrand <adg@golang.org>